Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule edit: Generate suggested trigger title only when none is available #2377

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 18, 2024

This lets the helper library provide a more accurate label for custom triggers

Related: openhab/openhab-jruby#254

image

@jimtng jimtng requested a review from a team as a code owner February 18, 2024 17:47
Copy link

relativeci bot commented Feb 18, 2024

Job #1595: Bundle Size — 11.01MiB (~+0.01%).

281740a(current) vs 260389b main#1593(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1595
     Baseline
Job #1593
No change  Initial JS 1.84MiB 1.84MiB
No change  Initial CSS 607.89KiB 607.89KiB
Change  Cache Invalidation 16.96% 17.34%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3087 3087
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.77% 1.77%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1595
     Baseline
Job #1593
Regression  JS 9.2MiB (~+0.01%) 9.2MiB
Not changed  CSS 889.37KiB 889.37KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1595 reportView jimtng:script-edit-file-triggers branch activityView project dashboard

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 changed the title Generate suggested trigger title only when none is available Rule edit: Generate suggested trigger title only when none is available Feb 18, 2024
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Feb 18, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 18, 2024
@florian-h05 florian-h05 merged commit c703f4b into openhab:main Feb 18, 2024
6 checks passed
@jimtng jimtng deleted the script-edit-file-triggers branch February 18, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants