Metadata: Add link_to_more as well-known namespace
#2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes openhab#2382. Adds Android app's link_to_more metadata to the well-known namespaces, therefore also adds an editing page for it. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
@mueller-ma Please let me know what you think about the label and the description (have a look at the screenshots, which are behind the expandable "Screenshot"). |
Job #1908: Bundle Size — 10.56MiB (~+0.01%).Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current Job #1908 |
Baseline Job #1905 |
|
|---|---|---|
 Initial JS |
1.86MiB |
1.86MiB |
| Initial CSS |
607.87KiB |
607.87KiB |
 Cache Invalidation |
18.48% |
17.88% |
| Chunks |
223 |
223 |
| Assets |
246 |
246 |
| Modules |
2864(+0.1%) |
2861 |
| Duplicate Modules |
141 |
141 |
| Duplicate Code |
1.73% |
1.73% |
| Packages |
95 |
95 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 1 change 
1 regression
| Current Job #1908 |
Baseline Job #1905 |
|
|---|---|---|
| JS |
8.75MiB (+0.01%) |
8.75MiB |
| CSS |
890.07KiB |
890.07KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.24KiB |
1.24KiB |
| Other |
871B |
871B |
View job #1908 report View florian-h05:metadata_linktomore branch activity View project dashboard
mueller-ma
reviewed
Apr 21, 2024
bundles/org.openhab.ui/web/src/assets/definitions/metadata/namespaces.js
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/components/item/metadata/item-metadata-linktomore.vue
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/components/item/metadata/item-metadata-linktomore.vue
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/components/item/metadata/item-metadata-linktomore.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: mueller-ma <mueller-ma@users.noreply.github.com> Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
@mueller-ma Thanks for the suggestions, I have applied them all. |
mueller-ma
reviewed
Apr 21, 2024
bundles/org.openhab.ui/web/src/components/item/metadata/item-metadata-linktomore.vue
Outdated
Show resolved
Hide resolved
|
Thanks for implementing it. Looks good so far beside my last comment. |
…etadata-linktomore.vue Co-authored-by: mueller-ma <mueller-ma@users.noreply.github.com> Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2382.
Refs openhab/openhab-android#3140.
Adds Android app's link_to_more metadata to the well-known namespaces, therefore also adds an editing page for it.
Screenshots