Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup wizard: Improve suggestions refresh on network change #2568

Merged
merged 2 commits into from
May 15, 2024

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented May 7, 2024

@florian-h05 I was working on an improvement in parallel with your improvements and merge. Thank you for your improvements.
When I was testing it, I still saw 2 issues I tried to resolve:

  1. There would also be a delay when setting the network without a change. This is not required.
  2. While in the wait cycle, going back to the network selection and setting the network again (with or without change) would lead to the progress bar alternating between short and long because 2 timer cycles would be running in parallel. I now cancel the existing timer if there is a real network change.

I hope these improvements still make sense.

@mherwege mherwege requested a review from a team as a code owner May 7, 2024 14:15
Copy link

relativeci bot commented May 7, 2024

#1958 Bundle Size — 10.6MiB (~+0.01%).

5a0ccdf(current) vs 5282f44 main#1955(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#1958
     Baseline
#1955
No change  Initial JS 1.86MiB 1.86MiB
No change  Initial CSS 607.87KiB 607.87KiB
Change  Cache Invalidation 17.75% 18.16%
No change  Chunks 223 223
No change  Assets 246 246
No change  Modules 2876 2876
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.86% 1.86%
No change  Packages 95 95
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#1958
     Baseline
#1955
Regression  JS 8.79MiB (~+0.01%) 8.79MiB
No change  CSS 890.75KiB 890.75KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.24KiB 1.24KiB
No change  Other 871B 871B

Bundle analysis reportBranch mherwege:primary_ip_configProject dashboard

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I just pushed a minor JSDoc improvement, other then this I changed nothing.

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels May 15, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone May 15, 2024
mherwege and others added 2 commits May 15, 2024 10:58
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 merged commit d8016b6 into openhab:main May 15, 2024
8 checks passed
@florian-h05 florian-h05 changed the title Setup Wizard: improve suggestions refresh on network change Setup wizard: Improve suggestions refresh on network change May 15, 2024
@mherwege mherwege deleted the primary_ip_config branch May 15, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants