Conversation
thanks :-) May i finally ask you to check the compatibility against OH2? So simply use the OH2 runtime and deploy your binding there (throw it into /addons dir) and see if it works. Thanks, Thomas E.-E. |
Hi Thomas, Regards |
welcome to the future of openHAB … would be great btw if you could go ahead with the implementation and enhance your binding to be OH2 compatible (e.g. implementation of discovery). Will you? |
Yes, definitely. I think I'll first implement one or two missing devices and will then take a look at OH2. |
great! Could you finally please resolve the conflicts that currently occur (keep in mind to squash commits again afterwards). Thanks, Thomas E.-E. |
dc58efb
to
5912bfb
Compare
I fear I have to create another PR again. I still don't know how to do it. I read the attlassian git tutorial, googled for hours, followed these steps (https://www.youtube.com/watch?v=b1K_oZX02KU) to resolve the conflicts and now have a branch mixed up with some master commits from other bindings and still have conflicts remaining. Why must this be so complicated? Is there a good tutorial out there about how to do it step by step? |
well, i would call it "complicated" but probably "not so obvious" ;-) Let's go through some steps:
Hope this helps, Thomas E.-E. |
@ollie-dev i tried out your binding but didn't manage to logon successfully. sResponse in logon() always returns an empty String. Any idea what that might be about? |
ah this might be a consecutive fault of
|
Yeah, you have to use java 1.7 or force 1.8 to use TLSv1 by adding |
5707cdf
to
4785937
Compare
ok, that's it, thanks! The should definitely be part of the wiki page ;-) |
All right, @teichsta - I think I finally made it. Puh! I already prepared a Wiki page: https://github.com/openhab/openhab/wiki/RWE-Smarthome-binding :) |
4785937
to
a7084ca
Compare
a7084ca
to
e335c06
Compare
@teichsta, is everything fine now for you to accept the PR or is still something missing in your opinion? |
no, nothing missing … just lack of time again. Again, many thanks for this contribution! Hope to see many more from you :-) |
Implemented RWE Smarthome binding
Nice. @ollie-dev 😄 could I ask you to write a short announcement on https://community.openhab.org/c/add-ons/bindings when your new binding is in tonights nightly build? |
@hakan42 - yes! :D I am only a bit confused because the binding is available here... https://openhab.ci.cloudbees.com/job/openHAB/lastSuccessfulBuild/org.openhab.binding$org.openhab.binding.rwesmarthome/ ?!? |
overlooked that in the Review. Please add your binding to:
and send a PR for that. Would you? Thanks, Thomas E.-E. |
Hi, |
This is the RWE Smarthome binding with all changes as discussed in #3143. Sorry for the double PRs due to my git inability...
Best regards
Ollie