Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

Enocean binding tests do not support concurrent test execution #3895

Open
dvanherbergen opened this issue Jan 25, 2016 · 1 comment
Open

Comments

@dvanherbergen
Copy link
Contributor

dvanherbergen commented Jan 25, 2016

To improve performance of the automated builds, I tried building using multiple concurrent threads: mvn -T 2 clean install. During these build, the enocean tests occasionally failed.

org.openhab.binding.enocean.internal.bus.RockerSwitchInDimmerOnOffProfileTest.lightenUpDuringVeryLongButtonPressDown

Update State expected:<INCREASE> but was:<null>
Stacktrace

java.lang.AssertionError: Update State expected:<INCREASE> but was:<null>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)
    at org.junit.Assert.assertEquals(Assert.java:118)
    at org.openhab.binding.enocean.internal.bus.RockerSwitchInDimmerOnOffProfileTest.lightenUpDuringVeryLongButtonPressDown(RockerSwitchInDimmerOnOffProfileTest.java:90)
org.openhab.binding.enocean.internal.bus.RockerSwitchInDimmerOnOffProfileTest.dimmLightDuringLongButtonPressUp

Update State expected:<DECREASE> but was:<null>
Stacktrace

java.lang.AssertionError: Update State expected:<DECREASE> but was:<null>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)
    at org.junit.Assert.assertEquals(Assert.java:118)
    at org.openhab.binding.enocean.internal.bus.RockerSwitchInDimmerOnOffProfileTest.dimmLightDuringLongButtonPressUp(RockerSwitchInDimmerOnOffProfileTest.java:104)

Failure was not consistent and not reproducable on a fast machine.

The tests should be updated so that they can be executed in parallel.

@martinvw
Copy link
Member

I see this test failing frequently on the cloudbees buildserver too, don't know if it uses multiple concurrent threads.

hubermi pushed a commit to hubermi/openhab that referenced this issue Jan 10, 2017
Signed-off-by: Gaël L'hopital <glhopital@gmail.com>

Take in account informations uploaded by bugs openhab#3891 and openhab#3895 on OH1
version of the binding.

Corrections following code review

Signed-off-by: Gaël L'hopital <glhopital@gmail.com>

Added feature.xml

Documentation update, code reviewed after Kai's observations

Signed-off-by: Gaël L'hopital <glhopital@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants