Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTTP] Support PUT/PATCH with request body #5845

Open
simonihmig opened this issue Apr 7, 2019 · 2 comments

Comments

@simonihmig
Copy link

commented Apr 7, 2019

Expected Behavior

http=">[<command>:PUT:<url>:<bodycontent>]" should send a PUT request with <bodycontent> as the HTTP body.

Current Behavior

Sending a HTTP body is constrained to POST requests only, hardcoded here: https://github.com/openhab/openhab1-addons/blob/master/bundles/binding/org.openhab.binding.http/src/main/java/org/openhab/binding/http/internal/HttpBinding.java#L279

Possible Solution

Support PUT and PATCH requests in the same way as POST.

Context

In a RESTful API, sending a POST means creating a resource, which you rarely would want to do in a binding. Usually you would update a resource (i.e. change its state), which is represented by a PUT or PATCH request, with the HTTP body containing the data to be changed (e.g. JSON). So this would a common use case for a binding, but is currently not supported.

@kohlsalem

This comment has been minimized.

Copy link

commented Sep 11, 2019

Here https://community.openhab.org/t/http-binding-for-homepilot-wrong/81669/5 i found the same issue. In my cuase PUT is mandatory. It would be nice, if somebody could have a look and fix that; does not look impossible to people having the IDE set up....

I havily dislike to work around this with rules; I offer a bug bounty in form of a PIZZA as a little thanks for the one who would look after that....

(== i order it to you or Paypal 10€)

@openhab-5iver

This comment has been minimized.

Copy link

commented Sep 11, 2019

There is work being done on a 2.x version of the binding, so you may want to request this feature there. Though it may be included already.

openhab/openhab2-addons#4342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.