New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance onewire binding #592

Closed
openhab-bot opened this Issue Nov 17, 2013 · 19 comments

Comments

Projects
None yet
6 participants
@openhab-bot
Collaborator

openhab-bot commented Nov 17, 2013

From henrik.sjostrand on August 09, 2012 23:07:38

Here are some feature requests that I'd like to see go into the onewire binding:

  1. Per-device configurable polling interval

I'm thinking if we should enhance the onewire binding and specify an (optional) polling interval for each device. An easy way to do that would be to just add the polling interval such as
{ onewire="1F.A96005000000/main/10.5FB813020800#temperature#300" } where 300 means poll every 5 minutes (300s). Then the onewire binding could be configured in openhab.cfg to execute e.g. every second, and the code enhanced to keep a list of the last polling time for each device. If a device does not need to be polled at an execution cycle it is simply skipped.

  1. Retry in case Undefined is returned

I keep getting Undefined values back randomly (so e.g. a temp sensor may report some successful values and then one or more Undefined). I think that adding a retry parameter (in openhab.cfg) and in case no value was received from a sensor the onewire binding could retry the poll.

/Henrik

Original issue: http://code.google.com/p/openhab/issues/detail?id=98

@openhab-bot

This comment has been minimized.

Show comment
Hide comment
@openhab-bot

openhab-bot Nov 17, 2013

Collaborator

From kai.openhab on August 09, 2012 15:17:13

Owner: teichsta

Collaborator

openhab-bot commented Nov 17, 2013

From kai.openhab on August 09, 2012 15:17:13

Owner: teichsta

@openhab-bot

This comment has been minimized.

Show comment
Hide comment
@openhab-bot

openhab-bot Nov 17, 2013

Collaborator

From teichsta on August 10, 2012 00:21:54

Status: Accepted

Collaborator

openhab-bot commented Nov 17, 2013

From teichsta on August 10, 2012 00:21:54

Status: Accepted

@openhab-bot

This comment has been minimized.

Show comment
Hide comment
@openhab-bot

openhab-bot Nov 17, 2013

Collaborator

From griffit...@gmail.com on October 12, 2012 19:56:24

Here is another feature request from someone whose water freezes at 32 degrees.

  1. Configurable temperature scale via a parameter in openhab.cfg. It looks like it's hard-coded to Celsius in OneWireBinding .java, though the enum also has values for Fahrenheit, Rankine, and Kelvin.

This seemed like a good place for this... I apologize if I should have made it a new issue instead.

Collaborator

openhab-bot commented Nov 17, 2013

From griffit...@gmail.com on October 12, 2012 19:56:24

Here is another feature request from someone whose water freezes at 32 degrees.

  1. Configurable temperature scale via a parameter in openhab.cfg. It looks like it's hard-coded to Celsius in OneWireBinding .java, though the enum also has values for Fahrenheit, Rankine, and Kelvin.

This seemed like a good place for this... I apologize if I should have made it a new issue instead.

@openhab-bot

This comment has been minimized.

Show comment
Hide comment
@openhab-bot

openhab-bot Nov 17, 2013

Collaborator

From teichsta on October 21, 2012 06:11:43

temperature scale is now configurable!

See: http://code.google.com/p/openhab/source/detail?r=0d11b4a0a72201a13c13fdcd5c038462571f6acb Regards,

Thomas E.-E.

Collaborator

openhab-bot commented Nov 17, 2013

From teichsta on October 21, 2012 06:11:43

temperature scale is now configurable!

See: http://code.google.com/p/openhab/source/detail?r=0d11b4a0a72201a13c13fdcd5c038462571f6acb Regards,

Thomas E.-E.

@openhab-bot

This comment has been minimized.

Show comment
Hide comment
@openhab-bot

openhab-bot Nov 17, 2013

Collaborator

From henrik.sjostrand on November 29, 2012 12:50:52

Have rewritten the OneWire binding using the 1.1. Plugwise binding as a model. Onewire now supports flexible per-device polling intervals. Code not finalized as of today (Nov 29), but working on it.

Collaborator

openhab-bot commented Nov 17, 2013

From henrik.sjostrand on November 29, 2012 12:50:52

Have rewritten the OneWire binding using the 1.1. Plugwise binding as a model. Onewire now supports flexible per-device polling intervals. Code not finalized as of today (Nov 29), but working on it.

@openhab-bot

This comment has been minimized.

Show comment
Hide comment
@openhab-bot

openhab-bot Nov 17, 2013

Collaborator

From teichsta on November 29, 2012 12:52:49

thanks for the update Henrik!

Collaborator

openhab-bot commented Nov 17, 2013

From teichsta on November 29, 2012 12:52:49

thanks for the update Henrik!

@openhab-bot

This comment has been minimized.

Show comment
Hide comment
@openhab-bot

openhab-bot Nov 17, 2013

Collaborator

From abode...@gmail.com on January 14, 2013 02:29:31

it is possible to enhance the onewire binding to read ibuttons? Please look at http://knx-user-forum.de/special/Digitales%20Schluesselbrett%20mit%201-Wire%20iButtons/ regards ansgar

Collaborator

openhab-bot commented Nov 17, 2013

From abode...@gmail.com on January 14, 2013 02:29:31

it is possible to enhance the onewire binding to read ibuttons? Please look at http://knx-user-forum.de/special/Digitales%20Schluesselbrett%20mit%201-Wire%20iButtons/ regards ansgar

@openhab-bot

This comment has been minimized.

Show comment
Hide comment
@openhab-bot

openhab-bot Nov 17, 2013

Collaborator

From henrik.sjostrand on January 15, 2013 00:15:04

As long as iButtons are supported over OWFS (OneWire File System) and the jowfsclient library we use in the Openhab onewire binding also supports it it should be doable. I would need to look into that and also get some iButton devices to test with.

We have other features of the onewire binding that currently are higher priority but we'll put iButton support on the wish list.

/Henrik

Collaborator

openhab-bot commented Nov 17, 2013

From henrik.sjostrand on January 15, 2013 00:15:04

As long as iButtons are supported over OWFS (OneWire File System) and the jowfsclient library we use in the Openhab onewire binding also supports it it should be doable. I would need to look into that and also get some iButton devices to test with.

We have other features of the onewire binding that currently are higher priority but we'll put iButton support on the wish list.

/Henrik

@openhab-bot

This comment has been minimized.

Show comment
Hide comment
@openhab-bot

openhab-bot Nov 17, 2013

Collaborator

From c.hoefl...@gmail.com on June 25, 2013 11:01:07

@henrik.sjostrand is your code commited? I have not seen it...

If not, I have another suggestion (and I could help to implement it). Defining a ratio per device, a ratio means that the base polling time is multiplied by the ratio, that number is the polling time of the device.
The advantage of this is that the system could distribute the pollings per ratio evenly.
If for example all temperature sensors have 300s, then every 300th second all temperatures are polled and the devices without different poll time like switches. That poll could take a lot of time.

Collaborator

openhab-bot commented Nov 17, 2013

From c.hoefl...@gmail.com on June 25, 2013 11:01:07

@henrik.sjostrand is your code commited? I have not seen it...

If not, I have another suggestion (and I could help to implement it). Defining a ratio per device, a ratio means that the base polling time is multiplied by the ratio, that number is the polling time of the device.
The advantage of this is that the system could distribute the pollings per ratio evenly.
If for example all temperature sensors have 300s, then every 300th second all temperatures are polled and the devices without different poll time like switches. That poll could take a lot of time.

@openhab-bot

This comment has been minimized.

Show comment
Hide comment
@openhab-bot

openhab-bot Nov 17, 2013

Collaborator

From teichsta on September 01, 2013 13:21:24

Hi Henrik, any news on regarding the 1-Wire binding? Best, Thomas E.-E.

Collaborator

openhab-bot commented Nov 17, 2013

From teichsta on September 01, 2013 13:21:24

Hi Henrik, any news on regarding the 1-Wire binding? Best, Thomas E.-E.

@openhab-bot

This comment has been minimized.

Show comment
Hide comment
@openhab-bot

openhab-bot Nov 17, 2013

Collaborator

From henrik.sjostrand on September 01, 2013 23:30:24

Hi Thomas,

Sorry, but haven't had any bandwidth over for Openhab at all this year.
I'm fully occupied developing a mobile app for Diabetes management for
children. So need to finish that project before I can go back to work
with Openhab again. And that is going to take me the remaining of 2013,
unfortunately.

/Henrik

Collaborator

openhab-bot commented Nov 17, 2013

From henrik.sjostrand on September 01, 2013 23:30:24

Hi Thomas,

Sorry, but haven't had any bandwidth over for Openhab at all this year.
I'm fully occupied developing a mobile app for Diabetes management for
children. So need to finish that project before I can go back to work
with Openhab again. And that is going to take me the remaining of 2013,
unfortunately.

/Henrik

@openhab-bot

This comment has been minimized.

Show comment
Hide comment
@openhab-bot

openhab-bot Nov 17, 2013

Collaborator

From teichsta on November 05, 2013 14:47:53

Labels: To-Github

Collaborator

openhab-bot commented Nov 17, 2013

From teichsta on November 05, 2013 14:47:53

Labels: To-Github

@openhab-bot openhab-bot closed this Dec 8, 2013

@teichsta teichsta reopened this Dec 8, 2013

@LennyLip

This comment has been minimized.

Show comment
Hide comment
@LennyLip

LennyLip Feb 4, 2014

Per-device configurable polling interval still not aviable?

LennyLip commented Feb 4, 2014

Per-device configurable polling interval still not aviable?

@teichsta

This comment has been minimized.

Show comment
Hide comment
@teichsta

teichsta Feb 4, 2014

Member

no …

Member

teichsta commented Feb 4, 2014

no …

@staehler

This comment has been minimized.

Show comment
Hide comment
@staehler

staehler Oct 2, 2014

I'ld love also the configurable polling intervall. Esp. my contact items (windows) need a smaller intervall than the temperatur sensors.
Maybe someone will find time to enhance the onewire-binding with this:
depending of the contact sensors openhab should be able to invert the result (open/closed). I'm no electrician, but depending if pull-up or pull-down layout of the sensor, the result will depend on.
My contacts give me the inverted result, so I need to invert this by rule at the moment.

staehler commented Oct 2, 2014

I'ld love also the configurable polling intervall. Esp. my contact items (windows) need a smaller intervall than the temperatur sensors.
Maybe someone will find time to enhance the onewire-binding with this:
depending of the contact sensors openhab should be able to invert the result (open/closed). I'm no electrician, but depending if pull-up or pull-down layout of the sensor, the result will depend on.
My contacts give me the inverted result, so I need to invert this by rule at the moment.

@AcidReptile

This comment has been minimized.

Show comment
Hide comment
@AcidReptile

AcidReptile Jan 30, 2015

Per-device configurable polling interval still not implemented?

AcidReptile commented Jan 30, 2015

Per-device configurable polling interval still not implemented?

@staehler

This comment has been minimized.

Show comment
Hide comment
@staehler

staehler Mar 12, 2015

The invert-Loginc of onewire has already implemented by Dennis (http://knx-user-forum.de/openhab/40551-one-wire-binding.html).
Hope this will be merged soon into openhab.

staehler commented Mar 12, 2015

The invert-Loginc of onewire has already implemented by Dennis (http://knx-user-forum.de/openhab/40551-one-wire-binding.html).
Hope this will be merged soon into openhab.

@Dennis650

This comment has been minimized.

Show comment
Hide comment
@Dennis650

Dennis650 Apr 1, 2015

Contributor

Hi, individual polling interval per device is implemented with this pull request: #2369

I don't know if the binding works with iButtons. I don't have hardware to test it.

Greetings
Dennis

Contributor

Dennis650 commented Apr 1, 2015

Hi, individual polling interval per device is implemented with this pull request: #2369

I don't know if the binding works with iButtons. I don't have hardware to test it.

Greetings
Dennis

@teichsta

This comment has been minimized.

Show comment
Hide comment
@teichsta

teichsta Oct 16, 2015

Member

since the original ideas have been implemented i'd like to close this issue. If there is need for an iButton issue please first discuss at https://community.openhab.org and then open an issue (in case)

Member

teichsta commented Oct 16, 2015

since the original ideas have been implemented i'd like to close this issue. If there is need for an iButton issue please first discuss at https://community.openhab.org and then open an issue (in case)

@teichsta teichsta closed this Oct 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment