New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denon binding #1910

Merged
merged 1 commit into from May 12, 2015

Conversation

Projects
None yet
3 participants
@idserda
Contributor

idserda commented Dec 30, 2014

Denon binding, still work in progress

Wiki page

TODO:

  • Support more commands (set surround mode, etc.)
  • Support more 'value' properties (audio/video info, if possible)
  • EPL headers
  • Javadoc
@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive Dec 30, 2014

openhab » openhab #1939 SUCCESS
This pull request looks good
(what's this?)

buildhive commented Dec 30, 2014

openhab » openhab #1939 SUCCESS
This pull request looks good
(what's this?)

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive Dec 31, 2014

openhab » openhab #1950 SUCCESS
This pull request looks good
(what's this?)

buildhive commented Dec 31, 2014

openhab » openhab #1950 SUCCESS
This pull request looks good
(what's this?)

@teichsta

This comment has been minimized.

Show comment
Hide comment
@teichsta

teichsta Jan 1, 2015

Member

Thanks @idserda, thanks for sharing this Binding. Please let us know if you are ready for Review. Best, Thomas E.-E.

Member

teichsta commented Jan 1, 2015

Thanks @idserda, thanks for sharing this Binding. Please let us know if you are ready for Review. Best, Thomas E.-E.

@teichsta teichsta added this to the 1.7.0 milestone Jan 1, 2015

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive Jan 6, 2015

openhab » openhab #2008 FAILURE
Looks like there's a problem with this pull request
(what's this?)

buildhive commented Jan 6, 2015

openhab » openhab #2008 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive Jan 6, 2015

openhab » openhab #2009 FAILURE
Looks like there's a problem with this pull request
(what's this?)

buildhive commented Jan 6, 2015

openhab » openhab #2009 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive Jan 7, 2015

openhab » openhab #2013 SUCCESS
This pull request looks good
(what's this?)

buildhive commented Jan 7, 2015

openhab » openhab #2013 SUCCESS
This pull request looks good
(what's this?)

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive Jan 10, 2015

openhab » openhab #2039 SUCCESS
This pull request looks good
(what's this?)

buildhive commented Jan 10, 2015

openhab » openhab #2039 SUCCESS
This pull request looks good
(what's this?)

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive Jan 17, 2015

openhab » openhab #2106 FAILURE
Looks like there's a problem with this pull request
(what's this?)

buildhive commented Jan 17, 2015

openhab » openhab #2106 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive Jan 18, 2015

openhab » openhab #2121 SUCCESS
This pull request looks good
(what's this?)

buildhive commented Jan 18, 2015

openhab » openhab #2121 SUCCESS
This pull request looks good
(what's this?)

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive Jan 19, 2015

openhab » openhab #2126 FAILURE
Looks like there's a problem with this pull request
(what's this?)

buildhive commented Jan 19, 2015

openhab » openhab #2126 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive Jan 19, 2015

openhab » openhab #2128 FAILURE
Looks like there's a problem with this pull request
(what's this?)

buildhive commented Jan 19, 2015

openhab » openhab #2128 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive Jan 19, 2015

openhab » openhab #2131 FAILURE
Looks like there's a problem with this pull request
(what's this?)

buildhive commented Jan 19, 2015

openhab » openhab #2131 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive Jan 20, 2015

openhab » openhab #2136 SUCCESS
This pull request looks good
(what's this?)

buildhive commented Jan 20, 2015

openhab » openhab #2136 SUCCESS
This pull request looks good
(what's this?)

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive Jan 24, 2015

openhab » openhab #2160 SUCCESS
This pull request looks good
(what's this?)

buildhive commented Jan 24, 2015

openhab » openhab #2160 SUCCESS
This pull request looks good
(what's this?)

@teichsta teichsta added the on-hold label Mar 27, 2015

@teichsta

This comment has been minimized.

Show comment
Hide comment
@teichsta

teichsta Mar 27, 2015

Member

Any news @idserda? Is this Binding ready for review? Best, Thomas E.-E.

Member

teichsta commented Mar 27, 2015

Any news @idserda? Is this Binding ready for review? Best, Thomas E.-E.

@idserda

This comment has been minimized.

Show comment
Hide comment
@idserda

idserda Apr 13, 2015

Contributor

@teichsta, this binding is now ready for review!

Contributor

idserda commented Apr 13, 2015

@teichsta, this binding is now ready for review!

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive Apr 13, 2015

openhab » openhab #2761 SUCCESS
This pull request looks good
(what's this?)

buildhive commented Apr 13, 2015

openhab » openhab #2761 SUCCESS
This pull request looks good
(what's this?)

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive Apr 14, 2015

openhab » openhab #2762 SUCCESS
This pull request looks good
(what's this?)

buildhive commented Apr 14, 2015

openhab » openhab #2762 SUCCESS
This pull request looks good
(what's this?)

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive Apr 14, 2015

openhab » openhab #2763 SUCCESS
This pull request looks good
(what's this?)

buildhive commented Apr 14, 2015

openhab » openhab #2763 SUCCESS
This pull request looks good
(what's this?)

@teichsta

View changes

Show outdated Hide outdated ...denon/src/main/java/org/openhab/binding/denon/internal/DenonBinding.java Outdated
@teichsta

View changes

Show outdated Hide outdated ...denon/src/main/java/org/openhab/binding/denon/internal/DenonBinding.java Outdated
@teichsta

View changes

Show outdated Hide outdated ...non/src/main/java/org/openhab/binding/denon/internal/DenonConnector.java Outdated
@teichsta

View changes

Show outdated Hide outdated ...non/src/main/java/org/openhab/binding/denon/internal/DenonConnector.java Outdated
@teichsta

View changes

Show outdated Hide outdated ...on/src/main/java/org/openhab/binding/denon/internal/DenonProperties.java Outdated
@teichsta

View changes

Show outdated Hide outdated ...non/src/main/java/org/openhab/binding/denon/internal/DenonConnector.java Outdated
@teichsta

View changes

Show outdated Hide outdated ...non/src/main/java/org/openhab/binding/denon/internal/DenonConnector.java Outdated
@teichsta

View changes

Show outdated Hide outdated ...java/org/openhab/binding/denon/internal/DenonGenericBindingProvider.java Outdated
@teichsta

View changes

Show outdated Hide outdated ...enon/src/main/java/org/openhab/binding/denon/internal/DenonListener.java Outdated
@teichsta

View changes

Show outdated Hide outdated ...enon/src/main/java/org/openhab/binding/denon/internal/DenonListener.java Outdated
@teichsta

View changes

Show outdated Hide outdated ...enon/src/main/java/org/openhab/binding/denon/internal/DenonListener.java Outdated
@teichsta

View changes

Show outdated Hide outdated ...enon/src/main/java/org/openhab/binding/denon/internal/DenonListener.java Outdated
@teichsta

View changes

Show outdated Hide outdated .../openhab/binding/denon/internal/communication/adapters/OnOffAdapter.java Outdated
@teichsta

View changes

Show outdated Hide outdated ...openhab/binding/denon/internal/communication/adapters/StringAdapter.java Outdated
@teichsta

This comment has been minimized.

Show comment
Hide comment
@teichsta

teichsta Apr 30, 2015

Member

Hi @idserda, please find my review comments inline. Thanks, Thomas E.-E.

Member

teichsta commented Apr 30, 2015

Hi @idserda, please find my review comments inline. Thanks, Thomas E.-E.

@teichsta

This comment has been minimized.

Show comment
Hide comment
@teichsta

teichsta May 4, 2015

Member

any chance to get the feedback incorporated soon?

Member

teichsta commented May 4, 2015

any chance to get the feedback incorporated soon?

@idserda

This comment has been minimized.

Show comment
Hide comment
@idserda

idserda May 4, 2015

Contributor

Yes, almost ready. I'll probably push the changes tomorrow morning.

Contributor

idserda commented May 4, 2015

Yes, almost ready. I'll probably push the changes tomorrow morning.

@idserda

This comment has been minimized.

Show comment
Hide comment
@idserda

idserda May 5, 2015

Contributor

@teichsta Done, thanks for the feedback.

Contributor

idserda commented May 5, 2015

@teichsta Done, thanks for the feedback.

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive May 5, 2015

openhab » openhab #2900 SUCCESS
This pull request looks good
(what's this?)

buildhive commented May 5, 2015

openhab » openhab #2900 SUCCESS
This pull request looks good
(what's this?)

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive May 5, 2015

openhab » openhab #2901 SUCCESS
This pull request looks good
(what's this?)

buildhive commented May 5, 2015

openhab » openhab #2901 SUCCESS
This pull request looks good
(what's this?)

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive May 6, 2015

openhab » openhab #2908 SUCCESS
This pull request looks good
(what's this?)

buildhive commented May 6, 2015

openhab » openhab #2908 SUCCESS
This pull request looks good
(what's this?)

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive May 6, 2015

openhab » openhab #2909 SUCCESS
This pull request looks good
(what's this?)

buildhive commented May 6, 2015

openhab » openhab #2909 SUCCESS
This pull request looks good
(what's this?)

@teichsta teichsta assigned teichsta and unassigned idserda May 12, 2015

@teichsta teichsta merged commit d9483b1 into openhab:master May 12, 2015

@teichsta

This comment has been minimized.

Show comment
Hide comment
@teichsta

teichsta May 12, 2015

Member

Thanks again @idserda. Could you please also link to the according Wiki page here? Best, Thomas E.-E.

Member

teichsta commented May 12, 2015

Thanks again @idserda. Could you please also link to the according Wiki page here? Best, Thomas E.-E.

@teichsta teichsta assigned idserda and unassigned teichsta May 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment