This repository was archived by the owner on May 17, 2021. It is now read-only.
Add a Data value selector that doesn't include RFXCOM headers#4520
Merged
Conversation
Contributor
Author
|
Assuming this is pulled into openhab, I next plan to upgrade my system to openhab2 and make the same changes. The code for undecoded messages hasn't reached openhab2-addons yet, so I'll port that in as well. |
Contributor
|
Thank you for this. Would you also please update the wiki to document the new "Data" value selector, noting that it will be available in 1.9 of the binding? |
Contributor
Author
|
Thanks. wiki updated. |
Contributor
|
Thank you very much, @Jamstah! |
cdjackson
added a commit
to cdjackson/openhab1-addons
that referenced
this pull request
Aug 12, 2016
* master: (41 commits) Zwave database 120816 (openhab#4585) Introduce a 20s delay before attempting to reconnect once connection (openhab#4549) [Modbus] Read errors now emit UNDEF (configurable) (openhab#4577) [modbus] PR 4575 small fix (openhab#4579) ZWave Database updates (openhab#4580) Modbus: enable tests that used to fail (openhab#4576) Modbus binding: do not read out-of-bounds discrete inputs/coils (openhab#4575) Influxdb update influxdb java api, make retentionPolicy configurable (openhab#4564) Add a Data value selector that doesn't include RFXCOM headers (openhab#4520) Fix demo links in readme (openhab#4572) ZWave database update (openhab#4571) Add binding IRTrans and Souliss to OH2 (openhab#4568) [+] snmp binding: added port support via url ("address/port" with specified port or "address" with default 161 port) (openhab#4474) Prevent NPE when neohub is down (openhab#4567) Thread interruption changes. (openhab#4566) Added new weather provider: MeteoBlue (openhab#4554) made Onkyo binding 1.x legacy as there is now a 2.0 version (openhab#4556) ZWave update kfob codes (openhab#4563) Fix for SqueezeboxSpeak volume. (openhab#4561) KNX start/stop dimming openhab#635 (openhab#3403) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Undecoded implementation only has one value selector, RawData. This updates the item state with the full message.
I'd like to introduce a "Data" value selector, which drops the header from the message. The bytes of the header are:
I have devices that just spit out their ID as a message and nothing else, by using the Data selector instead of the RawData selector, I get a consistent output (without sequence), which means my rules file can detect the state update really easily. With RawData, the value would change every time so would need more work.