Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed license from EPL v1 to EPL v2 #4623

Merged
merged 1 commit into from Jan 18, 2019

Conversation

Projects
None yet
4 participants
@Hilbrand
Copy link
Contributor

Hilbrand commented Jan 18, 2019

  • updated license headers
  • added NOTICE files
  • moved about.html to NOTICE files
  • moved third party license info from specific about.html to the bundle NOTICE files
  • changed main project license
  • updated license url in main pom
  • updated build.properties
  • added files to check to prevent error about missing about.html
  • updated checkstyle properties
  • updated skeleton scripts to copy NOTICE file
Changed license from EPL v1 to EPL v2
* updated license headers
* added NOTICE files
* moved about.html to NOTICE files
* moved third party license info from specific about.html to the bundle NOTICE files
* changed main project license
* updated license url in main pom
* updated build.properties
* added files to check to prevent error about missing about.html
* updated checkstyle properties
* updated skeleton scripts to copy NOTICE file

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

@Hilbrand Hilbrand requested a review from kaikreuzer Jan 18, 2019

@Hilbrand Hilbrand requested review from cweitkamp, davidgraeff, martinvw, wborn and openhab/2-x-add-ons-maintainers as code owners Jan 18, 2019

@wborn

This comment has been minimized.

Copy link
Member

wborn commented Jan 18, 2019

Thanks! This PR also shows that PRs touching all addons will trigger reviews from all code owners.

@Hilbrand

This comment has been minimized.

Copy link
Contributor Author

Hilbrand commented Jan 18, 2019

This change will very likely also break a lot of open pull request (that add new files, so at minimal all new bindings). So before merging any pr a rebuild should be triggered.

And all open pr's should be on hold before this gets merged (preferable).

@kaikreuzer

This comment has been minimized.

Copy link
Member

kaikreuzer commented Jan 18, 2019

Wow, you are really quick! And it looks excellent and complete. Just running a local build to make sure it all works.

I'd like to merge this asap as I need it as a prerequisite for my PR that merges the ESH add-ons.
Yes, a negative side effect is that it will break almost all open PRs - well, I guess we have to live with that.

@kaikreuzer
Copy link
Member

kaikreuzer left a comment

Looks all good, many thanks!

@kaikreuzer kaikreuzer merged commit 43726b4 into openhab:master Jan 18, 2019

2 of 3 checks passed

PR-openHAB2-Addons Build #12018 ended
Details
code-review/pullapprove Approved by kaikreuzer
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Hilbrand Hilbrand deleted the Hilbrand:update-license branch Jan 18, 2019

@openhab-bot

This comment has been minimized.

Copy link
Collaborator

openhab-bot commented Jan 19, 2019

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/the-road-ahead-reintegrating-esh/64670/15

@wborn

This comment has been minimized.

Copy link
Member

wborn commented Jan 20, 2019

Because this PR has removed src/etc/about.html SAT (also on ESH) now logs errors like:

java.io.IOException: Unable to get https://raw.githubusercontent.com/openhab/openhab2-addons/master/src/etc/about.html

I've created openhab/static-code-analysis#335 to disable the AboutHtmlCheck in SAT.

@wborn wborn added this to the 2.5 milestone Feb 28, 2019

ArjenKorevaar added a commit to ArjenKorevaar/openhab2-addons that referenced this pull request Mar 24, 2019

Changed license from EPL v1 to EPL v2 (openhab#4623)
* updated license headers
* added NOTICE files
* moved about.html to NOTICE files
* moved third party license info from specific about.html to the bundle NOTICE files
* changed main project license
* updated license url in main pom
* updated build.properties
* added files to check to prevent error about missing about.html
* updated checkstyle properties
* updated skeleton scripts to copy NOTICE file

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.