Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Nuvoton NCT6793D chip #884

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
@dernerv
Copy link

commented Dec 6, 2016

Added support for Nuvoton NCT6793D chip.
Tested on Asus ASUS Z170 Pro Gaming.

@terman110
Copy link

left a comment

Works like a charm on ASUS Z170 Pro Gaming and ASUS X99

@jtugsop

This comment has been minimized.

Copy link

commented Jan 26, 2017

Would love to see this pulled so Kaby Lake would be fully supported.

@jtugsop

This comment has been minimized.

Copy link

commented on 7938882 Feb 23, 2017

Did you create a build with this update that includes the other 7700k chip updates? I altered the source exactly as you posted but I can't compile it into an executable. Keeps throwing errors.

@@ -414,7 +415,7 @@ public NCT677X(Chip chip, byte revision, ushort port, LPCPort lpcPort)
public float?[] Controls { get { return controls; } }

private void DisableIOSpaceLock() {
if (chip != Chip.NCT6791D)
if (chip != Chip.NCT6791D || chip != Chip.NCT6793D)

This comment has been minimized.

Copy link
@martynsmall

martynsmall Apr 8, 2017

I believe this should be an && not a ||!

This comment has been minimized.

Copy link
@jakobx13

This comment has been minimized.

Copy link
@martynsmall

martynsmall Jul 7, 2017

100%, as it stands the condition will always be true. chip would have to be both NCT6791D and NCT6793D at the same time in order to fail the condition!

@martynsmall

This comment has been minimized.

Copy link

commented Apr 8, 2017

I tried making the same type of changes to add support for the NCT6795D chip (on an MSI Z270 PC Mate) using the ID 0xD352 and it seems to work well. It picks up a few more temperature sensors than seem to be connected to anything as three of them never change but I guess this is down to what the chip actually supports.

Do you think you could possibly add this support into your PR as well so there aren't two very similar ones that will need merging in future?

@nokitakaze

This comment has been minimized.

Copy link

commented May 6, 2017

approved

Ok. And what about always true condition in #884 (diff) ?

@DarthDestroyer

This comment has been minimized.

Copy link
Contributor

commented May 6, 2017

My approve doesnt do anything, but maybe it gets listen.
And yes, it should be && instead of ||!
But that is fixable, also when the pull gets accepted!

@myfreeweb

This comment has been minimized.

Copy link

commented Jul 16, 2017

I made a PR to the PR, for the 6795D dernerv#1 — works on my MSI X370 SLI PLUS.

Merge pull request #1 from myfreeweb/nct6795d
Add support for Nuvoton NCT6795D
@CHerSun
Copy link

left a comment

Can't find this in master branch, NCT6793D and NCT6795D are missing. Tested on ASrock J3455M motherboard - works finely.

@Dealman

This comment has been minimized.

Copy link

commented Nov 9, 2018

Thanks for this! In the process of making a custom PC case and will be making my own LCD temperature sensor. I've got an ASUS Z270 mainboard and the latest version of OHM did not report back my CPU temperature.

This merge fixed it without any issues.

@Slion

Slion approved these changes Nov 16, 2018

@TommyGKiwi

This comment has been minimized.

Copy link

commented Mar 16, 2019

Hi I read the Spec sheet for NCT6796D which is in Asus RoG Hero Xi
I made some changes to at least reflect better the correct registers..... (see below)
(1) temperaturesSource, correct order versus alt temps reference
(2)temperatureRegister were not referencing the correct locations for SMIOVT3-7
(3)PECI added to alternateTemperatureRegister

      temperatures = new float?[7];
      temperaturesSource = new byte[] {
        (byte)SourceNCT67XXD.PECI_0,
        (byte)SourceNCT67XXD.SYSTIN,
        (byte)SourceNCT67XXD.CPUTIN,
        (byte)SourceNCT67XXD.AUXTIN1,
        (byte)SourceNCT67XXD.AUXTIN2,
        (byte)SourceNCT67XXD.AUXTIN3,
        (byte)SourceNCT67XXD.AUXTIN4
      };

      temperatureRegister = new ushort[]
        { 0x027, 0x150, 0x670, 0x672, 0x674, 0x676, 0x678 };
      temperatureHalfRegister = new ushort[]
        { 0, 0x151, 0x671, 0x673, 0x675, 0x677, 0x679 };              
      temperatureHalfBit = new int[]
        { -1, 7, 7, 7, 7, 7, 7 };
      temperatureSourceRegister = new ushort[] 
        { 0x621, 0x622, 0xC26, 0xc27, 0xc28, 0xc29, 0xc2a };

      alternateTemperatureRegister = new ushort?[] 
        {0x720, 0x491, 0x490, 0x492, 0x493, 0x494, 0x495 };
@TommyGKiwi

This comment has been minimized.

Copy link

commented Jun 12, 2019

@TommyGKiwi

This comment has been minimized.

Copy link

commented Jun 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.