Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django-inplaceedit probably introduces some security holes #1335

Closed
imported-from-roundup opened this issue Aug 8, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@imported-from-roundup
Copy link

commented Aug 8, 2014

Comment by ehashman:

Asheesh and I are concerned about the POST handler django-inplaceedit provides.
It is possible that it provides arbitrary edit access to the database given the
software's authentication mechanism. See this request sequence:

[19/Jul/2014 16:45:22] "GET
/inplaceeditform/get_field/?field_name=status&module_name=annotatedbug&app_label=bugsets&can_auto_save=1&obj_id=4&font_size=12.95px&__widget_height=16px&__widget_width=71px
HTTP/1.1" 200 1072
[19/Jul/2014 16:45:26] "POST /inplaceeditform/save/ HTTP/1.1" 200 37

We should make sure that this new egg doesn't allow an attacker to, for
instance, change everyone's username to 'octamarine12345...'


Comment by ehashman:

lol this passes:
ehashman@e5f6765


Comment by ehashman:

We've demonstrated the ability to pwn the whole database---rather than set this
to priority = critical, I've closed this hole...

#307

As Asheesh commented on the PR, someone should possibly write more tests so we
should leave this open for now.


Status: chatting
Nosy List: bugZPDX, ehashman, paulproteus
Superceder : #"Bug set view" screen for Bug Set Creator
Priority: critical
Imported from roundup ID: 1020 (view archived page)
Last modified: 2014-07-19.23:42:15

@ehashman

This comment has been minimized.

Copy link
Member

commented Aug 17, 2014

I think this was fully addressed in #1346. Closing unless @paulproteus objects.

@ehashman ehashman closed this Aug 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.