Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Upgrade to Django 1.2: Make our models support model validation #532

Closed
imported-from-roundup opened this Issue · 0 comments

1 participant

@imported-from-roundup

Comment by paulproteus:

There are three things needed for us to upgrade to Django 1.2.

  1. Update buildout.cfg

(This is easy.)

  1. Start using the csrf_token template tag around all of our POST forms.

(This is easy enough.)

  1. http://docs.djangoproject.com/en/dev/releases/1.2/#model-validation

As of Django 1.2, when you save a ModelForm, you validate not just the submitted
form data, but you also check if that makes model valid.

Our models, apparently, are of low quality, and sometimes fail this validation
check. You can see that by running:

./bin/sqlite_mysite test profile.AddCitationManually

and watching it fail.

I've already done steps 1-2, and pushed that work to origin/django12 on Gitorious.

I'm filing this bug, but not going to work on it in the near future.


Comment by paulproteus:

You know, I think this is okay now.


Status: resolved
Nosy List: jesstess, paulproteus
Priority: wish
Imported from roundup ID: 217 (view archived page)
Last modified: 2011-05-01.00:03:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.