Comment by paulproteus:
Add an option to the "nagios" management command: -w
Make it CRITICAL if the Timestamp for the weekly project emails is older than
Comment by nacarino:
It looks very, very good. I'm going to increase my nitpickiness level and ask
that you remove the " " character at the end of the "return 0" line. Do that, and
resubmit, and I'll push it.
Before I deploy, I'll say: it would be nice if you also add an "integration"
One test for the CRITICAL case: with a fresh database, you would get a CRITICAL
return value. (This is because the Timestamp is set to 0 by default.)
One test for the OK case: if you call .handle() on the send_weekly_emails
management command, and then do the Nagios check, it should say things are OK.
(This is because running the send_weekly_emails management command should add a
Timestamp value that your nagios.py code picks up on.)
re: SSH key:
I'll deploy this to nagios@linode2 as soon as the patch above lands.
re: this bug:
There is a bug "status" called "needs-review". Mark the bug with that status to
make sure we see it. I'm also marking the bug as "Assigned To" you.
re: all of this:
This is totally excellent work. I really hope you stay involved! We have weekly
meetings to plan the release process, and discuss how our contributions are
going, and I hope you come to them.
In the future, try to keep related commits together. So the whitespace fixes
that aren't related to this commit's topic should be a separate commit/patch file.
I've pushed the patch. I still can't get Nagios to see the right things. But
your SSH key is there -- see https://openhatch.org/wiki/Monitoring for more info.
Comment by jesstess:
paulproteus: please review the testing branch and merge to master if everything looks good.
For future Nagios config changes, I recommend that we develop on a branch and have the author
set him/herself as the commit author. That'll make reviews and debugging easier.
jesstess: thanks for the suggested change in process. I like the changes. I
updated https://openhatch.org/wiki/Monitoring#Making_changes to match.
The changes themselves look good, too. Merged into "master"; "testing" branch
File at http://roundup-archive.openhatch.org/bugs/file162/0002-I-ve-added-the-management-command-w-to-check-for-the.patch by nacarino
File at http://roundup-archive.openhatch.org/bugs/file160/id_rsa.pub by nacarino
Nosy List: jesstess, nacarino, paulproteus
Imported from roundup ID: 332 (view archived page)
Last modified: 2011-03-24.14:47:44