Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix any and all pages caused by Django 1.5 url syntax #1365

Merged
merged 1 commit into from Aug 17, 2014

Conversation

Projects
None yet
4 participants
@ArcTanSusan
Copy link
Contributor

commented Aug 17, 2014

The "account/settings/location/" was broken, so it's fixed now in the
templates.

@ehashman

This comment has been minimized.

Copy link
Member

commented Aug 17, 2014

Suggestion: git grep 'url [^"]' to see if there's any more of these we've missed?

@coveralls

This comment has been minimized.

Copy link

commented Aug 17, 2014

Coverage Status

Coverage remained the same when pulling 7cbc89c on onceuponatimeforever:Fix-broken-account-pages into 49d685c on openhatch:master.

Susan Tan
Fix any and all broken pages caused by Django 1.5 url syntax
Fix 3 broken pages in the templates pages.

@ArcTanSusan ArcTanSusan changed the title Fix 2 broken pages caused by Django 1.5 url syntax Fix any and all pages caused by Django 1.5 url syntax Aug 17, 2014

@paulproteus

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2014

+1 to automated bug hunting, as suggested by ehashman

@ArcTanSusan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2014

OK!

@coveralls

This comment has been minimized.

Copy link

commented Aug 17, 2014

Coverage Status

Coverage remained the same when pulling 7fd9f81 on onceuponatimeforever:Fix-broken-account-pages into 49d685c on openhatch:master.

@ehashman

This comment has been minimized.

Copy link
Member

commented Aug 17, 2014

Yay, glad you found some more and they are now fixed.

ehashman added a commit that referenced this pull request Aug 17, 2014

Merge pull request #1365 from onceuponatimeforever/Fix-broken-account…
…-pages

Fix any and all pages caused by Django 1.5 url syntax

@ehashman ehashman merged commit b39bd28 into openhatch:master Aug 17, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@ArcTanSusan ArcTanSusan deleted the ArcTanSusan:Fix-broken-account-pages branch Aug 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.