Clean up parameter types. Fix for issue #676 #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oivind Ekelund <oivind.ekelund@silabs.com>
Silabs-ArjanB
requested changes
Mar 24, 2023
| @@ -24,13 +24,13 @@ | |||
| //////////////////////////////////////////////////////////////////////////////// | |||
|
|
|||
| module cv32e40x_mpu_sva import cv32e40x_pkg::*; import uvm_pkg::*; | |||
| #( parameter int PMA_NUM_REGIONS = 0, | |||
| #( parameter int PMA_NUM_REGIONS = 0, | |||
There was a problem hiding this comment.
IS_INSTR_SIDE should be 'bit' (might occur in other files as well)
Signed-off-by: Oivind Ekelund <oivind.ekelund@silabs.com>
Silabs-ArjanB
approved these changes
Mar 24, 2023
Silabs-ArjanB
added
the
Component:RTL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update most "parameter int" to "parameter int unsigned".
Binary parameters updated from "int" to "bit".
Note that PMA_NUM_REGIONS and DBG_NUM_TRIGGERS remain "parameter int" to avoid issues like the one reported in #39