Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sfence.vma decoder #921

Merged
merged 1 commit into from Jul 8, 2022
Merged

Conversation

Phantom1003
Copy link
Contributor

@Phantom1003 Phantom1003 commented Jun 23, 2022

from #876, this patch passed the testcase in the report.
The original design reset the illegal_instr during privilege check, use the previous value instead 0.

Copy link
Contributor

@zarubaf zarubaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks soo much for finding and fixing those! Greatly appreciated!

@JeanRochCoulon
Copy link
Contributor

LGTM

@JeanRochCoulon JeanRochCoulon merged commit 01c89b7 into openhwgroup:master Jul 8, 2022
2 of 7 checks passed
@Phantom1003 Phantom1003 deleted the dec_sfence branch July 8, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants