Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dret decoder #922

Merged
merged 1 commit into from
Jul 8, 2022
Merged

fix dret decoder #922

merged 1 commit into from
Jul 8, 2022

Conversation

Phantom1003
Copy link
Contributor

@Phantom1003 Phantom1003 commented Jun 23, 2022 •
edited
Loading

from #899, this patch passed the testcase in the report.
debug mode check reset the illegal_instr signal, use its previous value instead of 0.

@Phantom1003 Phantom1003 requested a review from zarubaf as a code owner June 23, 2022 13:33
zarubaf
zarubaf approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@zarubaf zarubaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@JeanRochCoulon
Copy link
Contributor

Thanks !

@JeanRochCoulon JeanRochCoulon merged commit 4ab5ef9 into openhwgroup:master Jul 8, 2022
@Phantom1003 Phantom1003 deleted the dec_dret branch July 8, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zarubaf zarubaf zarubaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Phantom1003 @JeanRochCoulon @zarubaf