Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fence(.i) decoder #923

Merged
merged 1 commit into from Jul 8, 2022
Merged

Conversation

Phantom1003
Copy link
Contributor

from #900, this patch passed the testcase in the report.
As specification suggests: For forward compatibility, base implementations shall ignore these fields, and standard software shall zero these fields, remove the check on related fields.

Copy link
Contributor

@zarubaf zarubaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! @JeanRochCoulon can you plaese check why the Invia pipeline fails?

@zarubaf
Copy link
Contributor

zarubaf commented Jul 7, 2022

Screenshot 2022-07-07 at 11 32 29
On the dashboard it shows as pass, but here it doesn't...

@JeanRochCoulon
Copy link
Contributor

Hello @zarubaf, Yesterday I was on the bitmanip merge. So from now, I am free to check this PR dashboard. I let you know! Cheers

@JeanRochCoulon
Copy link
Contributor

The CI is clean ! So we can merge ! Have a nice day

@JeanRochCoulon JeanRochCoulon merged commit 0b4ff9e into openhwgroup:master Jul 8, 2022
6 of 7 checks passed
@Phantom1003 Phantom1003 deleted the dec_fence branch July 8, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants