Skip to content

Demo app revamp #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 8, 2017
Merged

Demo app revamp #185

merged 3 commits into from
Mar 8, 2017

Conversation

@iainmcgin
Copy link
Member

@iainmcgin iainmcgin commented Mar 7, 2017 •
edited
Loading

  • Removes all references to Google from the app
  • Focuses the app on the single IDP use case
  • Demonstrates persisting authorization state to shared prefs
  • Enables Java 8 features, simplifies some asynchronous code

This change is Reviewable

Demo app revamp
9fdbc66 
- Removes all references to Google from the app
- Focuses the app on the single IDP use case
- Demonstrates persisting authorization state to shared prefs
- Enables Java 8 features, simplifies some asynchronous code
@iainmcgin
Copy link
Member Author

iainmcgin commented Mar 7, 2017

Context: http://lists.openid.net/pipermail/openid-specs-ab/Week-of-Mon-20170306/006456.html

@codecov-io
Copy link

codecov-io commented Mar 7, 2017 •
edited
Loading

Codecov Report

Merging #185 into master will decrease coverage by -3.62%.
The diff coverage is 75%.

@@             Coverage Diff              @@
##             master     #185      +/-   ##
============================================
- Coverage     82.83%   79.21%   -3.62%     
- Complexity        0      432     +432     
============================================
  Files            41       41              
  Lines          2132     2141       +9     
  Branches        204      206       +2     
============================================
- Hits           1766     1696      -70     
- Misses          366      367       +1     
- Partials          0       78      +78
Impacted Files Coverage Δ Complexity Δ
...penid/appauth/AuthorizationManagementActivity.java 81.92% <100%> (-4.98%) 18 <0> (+18)
library/java/net/openid/appauth/AuthState.java 75.54% <72.72%> (-8.94%) 78 <0> (+78)
.../net/openid/appauth/AdditionalParamsProcessor.java 76.66% <0%> (-10%) 9% <0%> (+9%)
library/java/net/openid/appauth/UriUtil.java 69.23% <0%> (-7.7%) 8% <0%> (+8%)
...va/net/openid/appauth/browser/BrowserSelector.java 86.79% <0%> (-7.55%) 17% <0%> (+17%)
...rary/java/net/openid/appauth/CodeVerifierUtil.java 58.62% <0%> (-6.9%) 8% <0%> (+8%)
...ava/net/openid/appauth/AuthorizationException.java 73.42% <0%> (-6.3%) 19% <0%> (+19%)
.../net/openid/appauth/browser/BrowserDescriptor.java 85.29% <0%> (-5.89%) 14% <0%> (+14%)
library/java/net/openid/appauth/TokenRequest.java 66.97% <0%> (-5.51%) 6% <0%> (+6%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de4c5a9...bfba993. Read the comment docs.

WilliamDenniss
WilliamDenniss approved these changes Mar 7, 2017
View reviewed changes
Copy link
Member

@WilliamDenniss WilliamDenniss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/README-Google.md Outdated
@@ -0,0 +1,35 @@
# Configuring Google Sign In
Copy link
Member

@WilliamDenniss WilliamDenniss Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google Sign In and OAuth?

Copy link
Member Author

@iainmcgin iainmcgin Mar 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll adopt the title you used in your readme, "Using AppAuth for Android with Google".

app/README.md Outdated
authorization option
flow with an authorization service. The configuration contained in `res/raw/idp_config.json`
must be modified in order for the app to function. Warnings are supplied when the app is run
if the configuration is invalid.
Copy link
Member

@WilliamDenniss WilliamDenniss Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"with an invalid configuration"

Copy link
Member Author

@iainmcgin iainmcgin Mar 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

app/README.md Outdated
generate this, or it can be done directly on the
[Google Developer Console](https://console.developers.google.com/apis/credentials?project=_).
- `redirect_uri` (required): The redirect URI to use for receiving the authorization response.
This can either be a custom scheme URI (example:/path) or an https app link
Copy link
Member

@WilliamDenniss WilliamDenniss Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

com.example.app:/oauth2redirect/example-provider is the example I use in the BCP. I know it was just an example, but technically example:/path would violate IANA requirements for private-use URI schemes (not domain-based).

Copy link
Member Author

@iainmcgin iainmcgin Mar 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@iainmcgin iainmcgin merged commit 29329dc into openid:master Mar 8, 2017
@iainmcgin iainmcgin mentioned this pull request Mar 8, 2017
Closed
@brandwe
Copy link

brandwe commented Mar 9, 2017

👍 @WilliamDenniss @iainmcgin - We will be doing our bit shortly for review.

@iainmcgin iainmcgin mentioned this pull request Mar 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WilliamDenniss WilliamDenniss WilliamDenniss approved these changes

@tikurahul tikurahul Awaiting requested review from tikurahul

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iainmcgin @codecov-io @brandwe @WilliamDenniss