Skip to content

Refactored Examples #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2017
Merged

Refactored Examples #80

merged 1 commit into from
Mar 7, 2017

Conversation

@WilliamDenniss
Copy link
Member

@WilliamDenniss WilliamDenniss commented Mar 6, 2017 •
edited
Loading

– Moved all examples into Examples/ folder.
– Removed all Google-specific information from source code and generic READMEs.
– Added a Google-specific read, and instructions for other OpenID Certified providers to do the same.

Per the announcement on-list.

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Mar 6, 2017 •
edited
Loading

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   76.05%   76.05%           
=======================================
  Files          39       39           
  Lines        2360     2360           
  Branches      123      123           
=======================================
  Hits         1795     1795           
  Misses        508      508           
  Partials       57       57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a62b491...7c15541. Read the comment docs.

@WilliamDenniss WilliamDenniss force-pushed the multi-idp branch 3 times, most recently from fd6a8ab to c11aaaa Compare March 6, 2017 03:18
@WilliamDenniss WilliamDenniss mentioned this pull request Mar 6, 2017
Closed
iainmcgin
iainmcgin reviewed Mar 7, 2017
View reviewed changes
Examples/Example-iOS_ObjC/README.md Outdated

## Configuration

The example doesn't work out of the box, you need to configure it your own
Copy link
Member

@iainmcgin iainmcgin Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"you need to configure it with your own client ID."

Copy link
Member Author

@WilliamDenniss WilliamDenniss Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Examples/Example-iOS_ObjC/README.md Outdated
* Client ID
* Redirect URI

The instructions on how to get this vary by IdP, but we have a
Copy link
Member

@iainmcgin iainmcgin Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"how to get this information varies by IDP"

Copy link
Member Author

@WilliamDenniss WilliamDenniss Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Examples/Example-iOS_ObjC/README.md Outdated
* Client ID
* Redirect URI

The instructions on how to get this vary by IdP, but we have a
Copy link
Member

@iainmcgin iainmcgin Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "a" from "but we have a docs"

Copy link
Member Author

@WilliamDenniss WilliamDenniss Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Examples/Example-iOS_ObjC/README.md Outdated
* Redirect URI

The instructions on how to get this vary by IdP, but we have a
[docs](../README.md#openid-certified-providers) for some OpenID Certified
Copy link
Member

@iainmcgin iainmcgin Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs -> instructions?

Copy link
Member Author

@WilliamDenniss WilliamDenniss Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Examples/Example-macOS/README.md
@@ -0,0 +1,53 @@
# Example Project
Copy link
Member

@iainmcgin iainmcgin Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments for this file apply as those for the iOS readme

Copy link
Member Author

@WilliamDenniss WilliamDenniss Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Examples/README-Google.md
@@ -0,0 +1,38 @@
# Using AppAuth for iOS and macOS with Google

To configure the sample with a Google OAuth client, first visit
Copy link
Member

@iainmcgin iainmcgin Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page is also excellent for quickly configuring an iOS client:

https://developers.google.com/mobile/add?platform=ios

Copy link
Member Author

@WilliamDenniss WilliamDenniss Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per our conversation, will keep as-is for now.

@WilliamDenniss
Refactored Examples.
7c15541 
– Moved all examples into Examples/ folder.
– Removed all Google-specific information from source code and generic READMEs.
– Added a Google-specific README, and instructions for other OpenID Certified providers to do the same.
@iainmcgin
Copy link
Member

iainmcgin commented Mar 7, 2017

LGTM

@WilliamDenniss WilliamDenniss merged commit 30f9bd2 into openid:master Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iainmcgin iainmcgin iainmcgin left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WilliamDenniss @codecov-io @iainmcgin