update session transcript section to use oid4vp annex b #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awoie
requested review from
Sakurann,
jogu,
leecam,
martijnharing and
timcappalli
timcappalli
approved these changes
Jan 7, 2025
Member
|
Missing document history entry |
Collaborator
Author
fixed |
c2bo
reviewed
Jan 8, 2025
| * `clientId` and `nonce` parameters in the Handover MUST be the `client_id` and `nonce` parameters included in the Authorization Request from the Verifier. | ||
| * `origin` in the Handover is the origin of the Verifer, obtained from the Web-platform and/or app platform. | ||
| * The `SessionTranscript` and `Handover` CBOR structures MUST be generated in accordance with Annex B.3.4.1 of [@!OIDF.OID4VP]. | ||
| * The hash function used to compute the `OID4VPDCAPIHandoverInfoHash` value in the `OID4VPDCAPIHandover` CBOR structure, as defined in Annex B.3.4.1, MUST be one of the following: SHA-256, SHA-384, SHA-512. |
Member
There was a problem hiding this comment.
Not entirely sure about this one, but we are currently only talking about sha-256 in HAIP (currently scoped to sd-jwt vc - https://openid.github.io/oid4vc-haip/openid4vc-high-assurance-interoperability-profile-wg-draft.html#section-9).
Would it make sense to remove that statement about hash functions here and move that into the general section profiling hash functions (perhaps with another PR, not this one)?
Collaborator
Author
There was a problem hiding this comment.
I updated the OID4VP PR to allow only SHA-256 since SessionTranscript is not transmitted. I updated this PR to reflect this change. Please review again @c2bo @timcappalli @hlozi @leecam @jogu .
c2bo
approved these changes
Jan 8, 2025
hlozi
approved these changes
Jan 8, 2025
hlozi
approved these changes
Jan 9, 2025
leecam
approved these changes
Jan 9, 2025
c2bo
approved these changes
Jan 10, 2025
tlodderstedt
approved these changes
Jan 10, 2025
Sakurann
approved these changes
Jan 14, 2025
Sakurann
pushed a commit
that referenced
this pull request
Jan 28, 2025
5 approvals. open for more than a week. wg approval to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the session transcript section:
fixes #135 but depends on merging openid/OpenID4VP#374