Remove the Wallet Attestation Schema and point to OpenID4VCI instead #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakurann
approved these changes
Jan 16, 2025
Contributor
Sakurann
left a comment
Sakurann
left a comment
There was a problem hiding this comment.
assuming Torsten's suggestions will be incorporated
Collaborator
Author
|
I would keep a dedicated section on wallet attestation, in case we have additional rules to it. I just forgot to rename the section title |
paulbastian
commented
Jan 16, 2025
peppelinux
reviewed
Jan 22, 2025
peppelinux
approved these changes
Jan 22, 2025
Member
peppelinux
left a comment
peppelinux
left a comment
There was a problem hiding this comment.
Ok, if OpenID4VCI will take all the good things we got here.
awoie
approved these changes
Jan 23, 2025
Collaborator
awoie
left a comment
awoie
left a comment
There was a problem hiding this comment.
Approving but noting that it is Annex E, not Annex D that defines Wallet Attestations in OID4VCI
paulbastian
commented
Jan 23, 2025
Co-authored-by: Giuseppe De Marco <demarcog83@gmail.com>
Sakurann
reviewed
Jan 23, 2025
Sakurann
pushed a commit
that referenced
this pull request
Jan 28, 2025
…153) 3 approvals. open for more than a week. no objections to merge during the WG call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #113