Add specific requirements for response encryption #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakurann
requested review from
Sakurann,
awoie,
c2bo,
danielfett,
jogu,
leecam,
paulbastian and
selfissued
Sakurann
reviewed
Jan 14, 2025
Sakurann
approved these changes
Jan 14, 2025
c2bo
reviewed
Jan 14, 2025
awoie
reviewed
Jan 14, 2025
bc-pi
commented
Jan 16, 2025
paulbastian
approved these changes
Jan 17, 2025
Collaborator
paulbastian
left a comment
paulbastian
left a comment
There was a problem hiding this comment.
Approved with the outstanding suggestion
c2bo
approved these changes
Jan 17, 2025
Member
c2bo
left a comment
c2bo
left a comment
There was a problem hiding this comment.
Approved if the re-wording of the MTI encryption algorithm section by Brian is accepted
awoie
approved these changes
Jan 17, 2025
Co-authored-by: Brian Campbell <71398439+bc-pi@users.noreply.github.com>
danielfett
approved these changes
Jan 17, 2025
Sakurann
approved these changes
Jan 17, 2025
danielfett
reviewed
Jan 17, 2025
Comment on lines
+233
to
+235
| * Response encryption MUST be performed as specified in [@!OIDF.OID4VP, section 7.3]. The JWE `alg` (algorithm) header parameter (see [@!RFC7516, section 4.1.1]) | ||
| value `ECDH-ES` (as defined in [@!RFC7518, section 4.6]), with key agreement utilizing keys on the `P-256` curve (see [@!RFC7518, section 6.2.1.1]) MUST be supported. | ||
| The JWE `enc` (encryption algorithm) header parameter (see [@!RFC7516, section 4.1.2]) value `A128GCM` (as defined in [@!RFC7518, section 5.3]) MUST be supported. |
Member
Author
There was a problem hiding this comment.
It self capitalizes somewhere in the tool chain https://openid.github.io/oid4vc-haip/openid4vc-high-assurance-interoperability-profile-wg-draft.html#section-6-2.4
Sakurann
pushed a commit
that referenced
this pull request
Jan 28, 2025
5 approvals. open for a week. executes WG agreement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #131 and discussions in openid/OpenID4VP#371 and kinda https://docs.google.com/document/d/1AJDDWuRG_b-MOBrAwhBoQV3dhH3LD31WNEQKzOB36SY/edit?tab=t.0 too