add key attestation to OpenID4VCI #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoGlastra
approved these changes
May 13, 2025
Sakurann
reviewed
May 20, 2025
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
jogu
approved these changes
Jun 11, 2025
Sakurann
approved these changes
Jun 26, 2025
c2bo
approved these changes
Jun 26, 2025
Contributor
|
Discussed on today's WG call (possibly after we'd moved onto the "unofficial" second hour of the call) - the only concerns people raised were around allowing other attestation forms, which we already have #188 open to discuss. This PR has been open for many weeks and has no unresolved comments and has 4 approvals, so meets our usual rules for merging and hence I'll merge it - thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #119