Skip to content

Conversation

@jogu
Copy link
Contributor

@jogu jogu commented Jul 23, 2025

x5c is required as per #178

This leaves it unsaid what iss is actually set to. I raised #215
in case we need to say something about that but think the scope of this PR should just be removing the text that is now inconsistent with other parts of HAIP.

x5c is required as per #178

This leaves it unsaid what iss is actually set to. I raised
#215
in case we need to say something about that but think the scope of this
PR should just be removing the text that is now inconsistent with
other parts of HAIP.
* The Issuer MUST NOT make any of the JWT Claims in the table above to be selectively disclosable, so that they are always present in the SD-JWT-VC presented by the Holder.
* It is at the discretion of the Issuer whether to use `exp` claim and/or a `status` claim to express the validity period of an SD-JWT-VC. The Wallet and the verifier MUST support both mechanisms.
* The `iss` claim MUST be an HTTPS URL. The `iss` value is used to obtain Issuer’s signing key as defined in (#issuer-key-resolution).
* The `iss` claim MUST be an HTTPS URL.
Copy link
Collaborator

@awoie awoie Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this requirement. Especially, since iss can be really confusing if the actual and verified issuer information is provided by x5c. Perhaps we would even need some language that says that.

Suggested change
* The `iss` claim MUST be an HTTPS URL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #215 for this - I do think we need a working group discussion on that topic, whereas removing the now incorrect sentence is hopefully straightforward.

Copy link
Contributor

@Sakurann Sakurann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't understand why the sentence being removed is inconsistent with the spec text? #issuer-key-resolution section still exists and defines how to obtain issuer key to validate sd-jwt vc. what's wrong with pointing to it?

@jogu
Copy link
Contributor Author

jogu commented Aug 7, 2025

i don't understand why the sentence being removed is inconsistent with the spec text? #issuer-key-resolution section still exists and defines how to obtain issuer key to validate sd-jwt vc. what's wrong with pointing to it?

The key resolution section says to use only the x5c claim to get the keys. The iss value is not used to get the Issuer's signing key, so saying that the iss value is used to get the issuer's signing key is not what ever happens. The key resolution section is still correct, but it's not related to the iss claim.

@Sakurann Sakurann requested a review from awoie August 19, 2025 17:50
Copy link
Collaborator

@awoie awoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but we need to address #215

@Sakurann Sakurann merged commit 9f48ed2 into main Aug 19, 2025
2 checks passed
@Sakurann Sakurann added this to the 1.0 Final milestone Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants