Modified Wording for Key Attestations #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awoie
reviewed
Jul 29, 2025
| ### Key Attestation {#key-attestation} | ||
|
|
||
| Wallets MUST support key attestations as defined in Annex D of [@!OIDF.OID4VCI]. If batch issuance is used, all public keys used in Credential Request SHOULD be attested within a single key attestation. | ||
| Wallets MUST support key attestations. If interoperability on the level of key attestations is required, such key attestations MUST conform to the definition in Annex D of [@!OIDF.OID4VCI], otherwise other key attestations formats can be used. |
Collaborator
There was a problem hiding this comment.
Suggested change
| Wallets MUST support key attestations. If interoperability on the level of key attestations is required, such key attestations MUST conform to the definition in Annex D of [@!OIDF.OID4VCI], otherwise other key attestations formats can be used. | |
| Wallets MUST support key attestations. If interoperability at the level of key attestations is required, such key attestations MUST conform to the definition in Annex D of [@!OIDF.OID4VCI], otherwise other key attestations formats can be used. |
Contributor
|
@tlodderstedt to update this PR with privacy/implementation considerations section |
Sakurann
approved these changes
Aug 7, 2025
jogu
approved these changes
Aug 12, 2025
Contributor
|
Discussed on today's WG call - Martijn to review then we'll merge. |
Co-authored-by: Christian Bormann <chris.bormann@gmx.de>
Contributor
|
wg discussion: will merge once 1-2 more approvals are in |
c2bo
approved these changes
Sep 16, 2025
martijnharing
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #188