require c_nonce for key bound creds #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awoie
requested review from
Sakurann,
bc-pi,
c2bo,
danielfett,
jogu,
paulbastian and
tplooker
jogu
approved these changes
Jul 29, 2025
Co-authored-by: Joseph Heenan <joseph@authlete.com>
charsleysa
approved these changes
Aug 7, 2025
Contributor
|
Agreement on today's WG call: one more review then we'll merge |
Sakurann
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic behind this and based on the following that is already in the OID4VCI spec:
cryptographic_binding_methods_supported, proof(s) have to be providednonce_endpointpresent, then wallet must providec_noncein proof(s)nonce_endpointpresent, then the issuer must check that the nonce in the proof(s) matches the providedc_nonceHence, all we need to do is to require
nonce_endpointto be present if there is a credential configuration that requires key binding.Editorially, I'm not sure if the newline is required @jogu
closes #149