prevent trust anchor certs to be included in x5c header #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbastian
reviewed
Aug 26, 2025
Collaborator
paulbastian
left a comment
paulbastian
left a comment
There was a problem hiding this comment.
Is this policy already included in ISO mdoc?
paulbastian
approved these changes
Aug 26, 2025
Collaborator
paulbastian
left a comment
paulbastian
left a comment
There was a problem hiding this comment.
if not required for ISO mdoc, lgtm
Collaborator
Author
Including the trust anchor is not required for ISO mdocs. |
c2bo
approved these changes
Aug 26, 2025
jogu
approved these changes
Aug 27, 2025
charsleysa
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents trust anchor certs to be included in x5c header. Fixes #237.