-
Notifications
You must be signed in to change notification settings - Fork 15
Add text explaining that some features rely on browser/OS support #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| ## Prerequisites | ||
|
|
||
| This specification assumes certain prerequisites, including browser/OS support of certain features (for example the `haip://` custom URL scheme). This means some of the mandatory clauses might not be implementable for reasons outside the implementer's control. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention both, custom URL scheme and DC API?
| This specification assumes certain prerequisites, including browser/OS support of certain features (for example the `haip://` custom URL scheme). This means some of the mandatory clauses might not be implementable for reasons outside the implementer's control. | |
| This specification assumes certain prerequisites, including browser/OS support of certain features (for example support for the `haip://` custom URL scheme or the Digital Credentials API within the browser). This means some of the mandatory clauses might not be implementable for reasons outside the implementer's control. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This specification assumes certain prerequisites, including browser/OS support of certain features (for example the `haip://` custom URL scheme). This means some of the mandatory clauses might not be implementable for reasons outside the implementer's control. | |
| The following mandatory clauses in this specification depend on browser and/or operating system support: | |
| - `haip://` custom URL scheme | |
| - Digital Credentials API | |
| This means there might be environments beyond the implementer's control where these clauses cannot be implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are two separate cases - if you can't do the DC API, you really can't do that whole flow at all - whereas you can support everything else in the redirect-based OID4VP flow without supporting haip://.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then would it make sense not to mention custom url schemes entirely?
| This specification assumes certain prerequisites, including browser/OS support of certain features (for example the `haip://` custom URL scheme). This means some of the mandatory clauses might not be implementable for reasons outside the implementer's control. | |
| Digital Credentials API related mandatory clauses in this specification depend on browser and/or operating system support. This means there might be environments beyond the implementer's control where these clauses cannot be implemented. |
|
|
||
| ## Prerequisites | ||
|
|
||
| This specification assumes certain prerequisites, including browser/OS support of certain features (for example the `haip://` custom URL scheme). This means some of the mandatory clauses might not be implementable for reasons outside the implementer's control. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed on this morning's WG call: The text here ends up generically applying to all 'MUST' in the spec, meaning that (e.g.) you could be compliant with a HAIP flow whilst (say) not implementing a mandatory encryption requirement. I may have misunderstood the working group intent here as that leads to a situation where interoperability would suffer.
We could instead make clear that some flows may not be implementable for reasons out of your control, and in that case the implementer can't implement that flow in a compliant way - meaning we may need some kind of "conditionality" or "optionality" for things like custom schemes that may not work in all situations. The text suggested in #240 (comment) seems like it works for custom schemes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i made a suggestion above to go one step further and be clear that the prerequisites described apply for specific two situations: custom schemes and DC API
|
I'm wondering if this is actually covered now that #266 is in (making the haip custom url scheme optional in the redirect flow) and we have #278 in progress (that makes clear that you can pick & choose whether to do DC API or not, and same for redirect based). I'm struggling to find anything else to say. |
|
WG discussion:
|
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
closes #136