Allow other Wallet Attestation formats #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakurann
approved these changes
Sep 30, 2025
jogu
reviewed
Oct 1, 2025
Contributor
jogu
left a comment
jogu
left a comment
There was a problem hiding this comment.
There seems to be a git conflict in the normative changes unfortunately - would be good if you can resolve that too please.
Co-authored-by: Joseph Heenan <joseph@authlete.com>
c2bo
requested review from
awoie,
danielfett,
jogu,
martijnharing and
paulbastian
jogu
approved these changes
Oct 2, 2025
Co-authored-by: Joseph Heenan <joseph@authlete.com>
jogu
changed the title
c2bo
force-pushed
the
211-wallet-attestation-formats
branch
from
4c98820 to
6b3fed3
Compare
awoie
reviewed
Oct 7, 2025
awoie
reviewed
Oct 7, 2025
awoie
reviewed
Oct 7, 2025
awoie
reviewed
Oct 7, 2025
awoie
reviewed
Oct 7, 2025
Co-authored-by: Oliver Terbu <oliver.terbu@mattr.global> Co-authored-by: Joseph Heenan <joseph@authlete.com>
awoie
reviewed
Oct 7, 2025
Co-authored-by: Oliver Terbu <oliver.terbu@mattr.global>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal making the wallet attestations format recommended instead of mandatory. Happy to change the text if we get consensus on the wg for a different path, but this seemed to be the current outcome?
closes #211