Skip to content

Conversation

@Sakurann
Copy link
Contributor

@Sakurann Sakurann commented Mar 20, 2024

closes #95

Copy link
Contributor

@jogu jogu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but we probably shouldn't merge it until the version of VP that is linked to actually contains the SD JWT VC profile :) (which I think means finishing the VP PR and publishing a numbered draft).

@javereec
Copy link
Contributor

Suggest to also correctly reference the Key Binding JWT (KB JWT) in the section on "Crypto Suites", now it says HB JWT, which I think references the KB JWT from the IETF SD-JWT VC spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Credential request parameters for IETF SD-JWT VCs on this profile seem inconsistent with OID4VCI's

6 participants