Add Credential Offer Flow for Authorized Code Flow in the introduction #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Code Flow Introduction and added use case example for Wallet-initiated flow. minor improvements on Section 3.4 and 3.5
tplooker
reviewed
Nov 25, 2023
tplooker
reviewed
Nov 25, 2023
Co-authored-by: Tobias Looker <tplooker@gmail.com>
Co-authored-by: Tobias Looker <tplooker@gmail.com>
peppelinux
reviewed
Nov 25, 2023
peppelinux
reviewed
Nov 25, 2023
peppelinux
reviewed
Nov 25, 2023
peppelinux
reviewed
Nov 25, 2023
peppelinux
reviewed
Nov 25, 2023
peppelinux
reviewed
Nov 25, 2023
peppelinux
reviewed
Nov 25, 2023
peppelinux
reviewed
Nov 25, 2023
peppelinux
reviewed
Nov 25, 2023
peppelinux
reviewed
Nov 25, 2023
peppelinux
reviewed
Nov 25, 2023
peppelinux
reviewed
Nov 25, 2023
peppelinux
reviewed
Nov 25, 2023
peppelinux
reviewed
Nov 25, 2023
peppelinux
reviewed
Nov 25, 2023
peppelinux
reviewed
Nov 25, 2023
peppelinux
reviewed
Nov 25, 2023
peppelinux
reviewed
Nov 25, 2023
peppelinux
requested changes
Nov 25, 2023
Member
peppelinux
left a comment
peppelinux
left a comment
There was a problem hiding this comment.
@paulbastian thank you very much, you saved to me a consistent amount of work with this PR
Co-authored-by: Giuseppe De Marco <demarcog83@gmail.com>
Contributor
Author
|
All comments resolved, ready for merge @Sakurann @tlodderstedt |
ju-cu
requested changes
Dec 12, 2023
Contributor
ju-cu
left a comment
ju-cu
left a comment
There was a problem hiding this comment.
Looks overall good but I found quite some issues. I will approve ones my comments have been addressed/resolved.
Co-authored-by: Judith <59833642+ju-cu@users.noreply.github.com>
…nID4VCI into credential_offer_flow
Co-authored-by: Judith <59833642+ju-cu@users.noreply.github.com>
Co-authored-by: Judith <59833642+ju-cu@users.noreply.github.com>
Co-authored-by: Judith <59833642+ju-cu@users.noreply.github.com>
Co-authored-by: Judith <59833642+ju-cu@users.noreply.github.com>
Co-authored-by: Judith <59833642+ju-cu@users.noreply.github.com>
Co-authored-by: Judith <59833642+ju-cu@users.noreply.github.com>
Co-authored-by: Judith <59833642+ju-cu@users.noreply.github.com>
Co-authored-by: Judith <59833642+ju-cu@users.noreply.github.com>
Co-authored-by: Judith <59833642+ju-cu@users.noreply.github.com>
Co-authored-by: Judith <59833642+ju-cu@users.noreply.github.com>
Co-authored-by: Judith <59833642+ju-cu@users.noreply.github.com>
Co-authored-by: Judith <59833642+ju-cu@users.noreply.github.com>
tlodderstedt
approved these changes
Dec 13, 2023
paulbastian
commented
Dec 13, 2023
Contributor
Author
|
all issues resolved except for one. |
tplooker
approved these changes
Dec 13, 2023
ju-cu
approved these changes
Dec 14, 2023
Contributor
ju-cu
left a comment
ju-cu
left a comment
There was a problem hiding this comment.
One final, minor comment on describing End-User authentication in the flow. I approve already because it's a subtle change.
Co-authored-by: Judith <59833642+ju-cu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also adding use case example for Wallet-initiated flow and some minor improvements to the sequence diagrams
Closes #76