Changing the structure of proof_types from an array to a proofs_supported map
#235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakurann
requested review from
TimoGlastra,
awoie,
c2bo,
danielfett,
decentralgabe,
jogu,
paulbastian,
peppelinux,
pmhsfelix,
tlodderstedt and
tplooker
TimoGlastra
reviewed
Jan 26, 2024
Co-authored-by: Timo Glastra <timo@animo.id>
Contributor
|
I can't figure out how to make a suggestion but this text on line 713 needs to fixed as it still mentions
|
jogu
requested changes
Jan 29, 2024
ghost
mentioned this pull request
bc-pi
reviewed
Jan 30, 2024
| * `proof_types`: OPTIONAL. Array of case sensitive strings, each representing a `proof_type` that the Credential Issuer supports, as defined in (#credential_request), one of which MUST be used in the Credential Request. If this array is non-empty and present, the Credential Issuer requires proof of possession of the cryptographic key material. If the parameter is omitted or the array is empty, the Credential Issuer does not require proof of possession of the cryptographic key material. | ||
| * `cryptographic_binding_methods_supported`: OPTIONAL. Array of case sensitive strings that identify the representation of the cryptographic key material that the issued Credential is bound to, as defined in (#credential-binding). Support for keys in JWK format [@!RFC7517] is indicated by the value `jwk`. Support for keys expressed as a COSE Key object [@!RFC8152] (for example, used in [@!ISO.18013-5]) is indicated by the value `cose_key`. When the Cryptographic Binding Method is a DID, valid values are a `did:` prefix followed by a method-name using a syntax as defined in Section 3.1 of [@!DID-Core], but without a `:`and method-specific-id. For example, support for the DID method with a method-name "example" would be represented by `did:example`. Support for all DID methods listed in Section 13 of [@DID_Specification_Registries] is indicated by sending a DID without any method-name. | ||
| * `credential_signing_alg_values_supported`: OPTIONAL. Array of case sensitive strings that identify the algorithms that the Issuer uses to sign the issued Credential. Algorithm names used are determined by the Credential format and are defined in (#format_profiles). | ||
| * `proofs_supported`: OPTIONAL. Object that describes specifics of the key proof(s) that the Credential Issuer supports. This object contains a list of name/value pairs, where each name is a unique identifier of the supported proof type(s). Valid values are defined in (#proof_types), other values MAY be used. This identifier is also used by the Wallet in the Credential Request as defined in (#credential_request). The value in the name/value pair is an object that contains metadata about the key proof and contains the following parameters defined by this specification: |
Member
There was a problem hiding this comment.
proof_types_supported (here and in the examples) I think was the agreed on name from the call
Member
There was a problem hiding this comment.
sorry if this is redundant w/ other comments/threads
tlodderstedt
approved these changes
Feb 1, 2024
TimoGlastra
approved these changes
Feb 1, 2024
bc-pi
approved these changes
Feb 1, 2024
jogu
approved these changes
Feb 1, 2024
TakahikoKawasaki
added a commit
to authlete/oid4vci-demo
that referenced
this pull request
Feb 2, 2024
…s_supported.json` to `credential_signing_alg_values_supported` to align with the breaking change made by openid/OpenID4VCI#235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #214. resolves #37
proof_typesfrom an array to aproofs_supportedmap that contains a requiredproof_signing_alg_values_supportedparameter (required to avoid having an empty object...).cryptographic_suites_supportedtocredential_signing_alg_values_supportedto clarify the purpose of the parameter.