Slightly reword the first sentence of the intro and include SD-JWT VC in the (non-exhaustive) list of formats #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the (non-exhaustive) list of formats
tplooker
approved these changes
Feb 6, 2024
Sakurann
approved these changes
Feb 6, 2024
jogu
approved these changes
Feb 6, 2024
selfissued
approved these changes
Feb 6, 2024
adeinega
reviewed
Feb 6, 2024
| # Introduction | ||
|
|
||
| This specification defines an API that is used to issue Verifiable Credentials. W3C formats [@VC_DATA] as well as other Credential formats, like [@ISO.18013-5], are supported. | ||
| This specification defines an OAuth protected API for the issuance of Verifiable Credentials. Credentials can be of any format, including, but not limited to, W3C formats [@VC_DATA], mDL [@ISO.18013-5], and SD-JWT VC [@I-D.ietf-oauth-sd-jwt-vc]. |
Member
There was a problem hiding this comment.
I don't want to be picky but not all endpoints defined in this specification are OAuth protected.
You might also want to use "Verifiable Credentials" in the second sentence.
Collaborator
There was a problem hiding this comment.
we are not talking about Authz/Token endpoints here. All endpoints used for the issuance (Credential, Batch, Deferred, Notification) are OAuth protected.
Member
There was a problem hiding this comment.
@Sakurann , I didn't refer to Authz/Token endpoints. This specification also defines & introduces /.well-known/openid-credential-issuer that isn't an OAuth protected API.
Collaborator
There was a problem hiding this comment.
Let's not be picky at that level in the introduction.
Sakurann
reviewed
Feb 7, 2024
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
c2bo
approved these changes
Feb 7, 2024
paulbastian
approved these changes
Feb 7, 2024
jogu
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly reword the first sentence of the intro and include SD-JWT VC in the (non-exhaustive) list of formats