Remove the duplicate requirement about not including query parameters to Credential Issuer Identifier #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Credential Issuer URL shouldn't already include the query component per 11.2.2. If an intent for the Wallet was to not add any query parameters for the Credential Issuer Identifier then this sentence should be changed to better reflect this.
Sakurann
reviewed
Feb 7, 2024
Collaborator
Sakurann
left a comment
Sakurann
left a comment
There was a problem hiding this comment.
if you are removing a normative statement, it is not an editorial change. please change the PR title accordingly
adeinega
changed the title
Contributor
|
Agree with the removal given both:
|
pmhsfelix
approved these changes
Feb 8, 2024
paulbastian
requested changes
Feb 8, 2024
Contributor
paulbastian
left a comment
paulbastian
left a comment
There was a problem hiding this comment.
The existing query statement is only refering to the the Credential Issuer Identifier.
I would propose to move this statement one paragraph earlier as:
"Credential Issuers publishing metadata MUST make a JSON document available at the path formed by concatenating the string /.well-known/openid-credential-issuer to the Credential Issuer Identifier. The resulting URL SHOULD NOT contain any query parameters"
selfissued
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Credential Issuer URL should not already include the query component per 11.2.2.
If an intent for the wallet was to not add any query parameters to the Credential Issuer Identifier when it fetches the metadata then this sentence should be changed to better reflect this.