add randomness to the credential_offer_uri #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbastian
reviewed
May 27, 2024
c2bo
reviewed
May 28, 2024
javereec
reviewed
May 28, 2024
paulbastian
approved these changes
Jun 3, 2024
Contributor
paulbastian
left a comment
paulbastian
left a comment
There was a problem hiding this comment.
approved regarding the outstanding suggestions
|
FYI: A real-world example showing two QR codes representing the same credential offer, one by value and the other by reference.
|
Co-authored-by: Tobias Looker <tobias.looker@mattr.global>
c2bo
approved these changes
Jun 10, 2024
Co-authored-by: Christian Bormann <8774236+c2bo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #295 as suggested in the issue comment