Jump to conversation
Unresolved conversations (3)
@Sakurann Sakurann Jun 17, 2024
can we please stick to `REQUIRED when` or `REQUIRED if` throughout the specification text?
Outdated
...d-4-verifiable-credential-issuance-1_0.md
@peppelinux peppelinux Jun 13, 2024
```suggestion * `format`: REQUIRED if `credential_identifiers` was not returned in the Token Response. It MUST NOT be used otherwise. This string specifies the format of the Credential to be issued, including type and related details. Credential Format Profiles, which detail format-specific parameters, are defined in (#format-profiles). When using this parameter, `credential_identifier` MUST NOT be present in the Credential Request. ```
Outdated
...d-4-verifiable-credential-issuance-1_0.md
@peppelinux peppelinux Jun 13, 2024
Credential Issuers MAY allow the request for authorization to issue a specific Credential using the `authorization_details` parameter.
Outdated
...d-4-verifiable-credential-issuance-1_0.md
Sakurann
Kristina
Resolved conversations (18)
@jogu jogu Jul 4, 2024
Discussed on today's WG call how to improve this language, this was the consensus: ```suggestion * `format`: REQUIRED if an Authorization Details of type `openid_credential` was not returned from the Token Response (e.g. when the credential was requested using a `scope` value in the authorization request or a pre-authorisation code was used that did not return an Authorization Details). It MUST NOT be used otherwise. A string that determines the format of the Credential to be issued, which may determine the type and any other information related to the Credential to be issued. Credential Format Profiles consist of the Credential format specific parameters that are defined in (#format-profiles). When this parameter is used, the `credential_identifier` Credential Request parameter MUST NOT be present. ```
Outdated
...d-4-verifiable-credential-issuance-1_0.md
@David-Chadwick David-Chadwick Jun 27, 2024
```suggestion Note: The `credential_identifiers` parameter cannot be used when the `scope` parameter is used in the Authorization Request to request issuance of a Credential. ```
Outdated
...d-4-verifiable-credential-issuance-1_0.md
David-Chadwick
David Chadwick
@David-Chadwick David-Chadwick Jun 27, 2024
```suggestion * `authorization_details`: REQUIRED when the `authorization_details` parameter is used to request issuance of a certain Credential Configuration as defined in (#authorization-details). It MUST NOT be used otherwise. It is an array of objects, as defined in Section 7 of [@!RFC9396]. In addition to the parameters defined in (#authorization-details), this specification defines the following parameter to be used with the authorization details type `openid_credential` in the Token Response: ```
Outdated
...d-4-verifiable-credential-issuance-1_0.md
@David-Chadwick David-Chadwick Jun 27, 2024
```suggestion The Wallet can use `authorization_details` in the Token Request to request a specific Credential Configuration in both the Authorization Code Flow and the Pre-Authorized Code Flow. The value of the `authorization_details` parameter is defined in (#(authorization-details)). ```
Outdated
...d-4-verifiable-credential-issuance-1_0.md
@jogu jogu Jun 26, 2024
It's not a problem introduced in this pull request, but I don't find the "the `credential_identifiers` parameter was returned from the Token Response" language clear, and in fact on first reading it confused me into thinking we were talking about a new top level element in the token endpoint response. Language that would be consistent with https://www.rfc-editor.org/rfc/rfc9396.html would be something like: ```suggestion * `credential_identifier`: REQUIRED when an Authorization Details of type `openid_credential` containing the `credential_identifiers` field was returned in the Token Response. It MUST NOT be used otherwise. A string that identifies a Credential Dataset that is requested for issuance. When this parameter is used, the `format` parameter and any other Credential format specific parameters such as those defined in (#format-profiles) MUST NOT be present. ``` (If we agree this is better language then there's other places it should be applied too.) Alternatively, given that credential_identifiers is now mandatory, we can simplify the language to "REQUIRED when an `authorization_details` of type `openid_credential` was returned in the Token Response".
Outdated
...d-4-verifiable-credential-issuance-1_0.md
jogu paulbastian
Joseph Heenan and Paul Bastian
@peppelinux peppelinux Jun 25, 2024
```suggestion * clarify optionality of scope and `authorization_details` for Authorization Request ```
Outdated
...d-4-verifiable-credential-issuance-1_0.md
@peppelinux peppelinux Jun 25, 2024
```suggestion Credential Issuers MAY support requesting authorization to issue a Credential using the `authorization_details` parameter. This is particularly useful, if the Credential Issuer offered multiple Credential Configurations in the Credential Offer of a Pre-Authorized Code Flow. ```
Outdated
...d-4-verifiable-credential-issuance-1_0.md
@peppelinux peppelinux Jun 25, 2024
```suggestion * make `credential_identifiers` mandatory for `authorization_details` flow ```
Outdated
...d-4-verifiable-credential-issuance-1_0.md
@Sakurann Sakurann Jun 17, 2024
```suggestion Credential Issuers MAY support requesting authorization to issue a Credential using the authorization_details parameter. This is particularly useful, if the Credential Issuer offered multiple Credential Configurations in the Credential Offer of a Pre-Authorized Code Flow. The Wallet can use `authorization_details` in the Token Request to request a specific Credential Configuration in both Authorization Code Flow and Pre-Authorized Code Flow. The value of the `authorization_details` parameter is defined in (#(authorization-details)). ``` I think this makes the point of this sentence clearer.
Outdated
...d-4-verifiable-credential-issuance-1_0.md
@Sakurann Sakurann Jun 17, 2024
```suggestion * clarify that authorization_details can be present in the Token Request for Pre-Authorized Code Flow when multiple Credential Configurations are present in the Credential Offer ``` I cannot interpret the current sentence..
Outdated
...d-4-verifiable-credential-issuance-1_0.md
@David-Chadwick David-Chadwick Jun 15, 2024
```suggestion * `credential_identifier`: REQUIRED when the `credential_identifiers` parameter was returned from the Token Response. It MUST NOT be used otherwise. A string that identifies a Credential Dataset that is requested for issuance. When this parameter is used, the `format` parameter and any other Credential format specific parameters such as those defined in (#format-profiles) MUST NOT be present. ```
Outdated
...d-4-verifiable-credential-issuance-1_0.md
@David-Chadwick David-Chadwick Jun 15, 2024
```suggestion * `format`: REQUIRED if the `credential_identifiers` parameter was not returned from the Token Response. It MUST NOT be used otherwise. A string that determines the format of the Credential to be issued, which may determine the type and any other information related to the Credential to be issued. Credential Format Profiles consist of the Credential format specific parameters that are defined in (#format-profiles). When this parameter is used, the `credential_identifier` Credential Request parameter MUST NOT be present. ```
Outdated
...d-4-verifiable-credential-issuance-1_0.md
@peppelinux peppelinux Jun 13, 2024
```suggestion Note: Credential Instance identifier(s) MUST NOT be used when the `scope` parameter is used in the Authorization Request to request issuance of a Credential. ```
Outdated
...d-4-verifiable-credential-issuance-1_0.md
Sakurann
Kristina
@peppelinux peppelinux Jun 13, 2024
```suggestion * `authorization_details`: REQUIRED if used to request a specific Credential Configuration as detailed in (#authorization-details). It MUST NOT be used for other purposes. This parameter is an array of objects, as defined in Section 7 of [@!RFC9396]. Additional parameters for the `openid_credential` type in the Token Response are defined in this specification. ```
Outdated
...d-4-verifiable-credential-issuance-1_0.md
Sakurann
Kristina
@peppelinux peppelinux Jun 13, 2024
```suggestion #### Request Issuance of a Certain Credential ``` making it a subsection doesn't need `using authorization_details Parameter`
...d-4-verifiable-credential-issuance-1_0.md
paulbastian
Paul Bastian
@peppelinux peppelinux Jun 13, 2024
```suggestion ### Using Authorization Details Parameter {#authorization-details} ```
Outdated
...d-4-verifiable-credential-issuance-1_0.md
@paulbastian paulbastian Jun 12, 2024
```suggestion * `format`: REQUIRED if the `credential_identifiers` parameter was not returned from the Token Response. It MUST NOT be used otherwise. String that determines the format of the Credential to be issued, which may determine the type and any other information related to the Credential to be issued. Credential Format Profiles consist of the Credential format specific parameters that are defined in (#format-profiles). When this parameter is used, the `credential_identifier` Credential Request parameter MUST NOT be present. ```
Outdated
...d-4-verifiable-credential-issuance-1_0.md
@paulbastian paulbastian Jun 12, 2024
```suggestion * `format`: REQUIRED if the `credential_identifiers` parameter was not returned from the Token Response. It MUST NOT be used otherwise. See (#credential-request). ```
Outdated
...d-4-verifiable-credential-issuance-1_0.md