gh-18: removes the Batch Credential Endpoint #364
Conversation
pmhsfelix
changed the title
peppelinux
left a comment
peppelinux
left a comment
There was a problem hiding this comment.
I have shared some editorials and normative language to better clarify some steps to the implementers. Approved!
babisRoutis
left a comment
babisRoutis
left a comment
There was a problem hiding this comment.
There are several proposed updates to the initial PR content that haven't been addressed.
IMO, all proposals make sense, yet I am not sure who should resolve them. Probably, @pmhsfelix
Anyway, assuming that the changes will find their way to the text, I think that it is ready.
Removes "multiple" Co-authored-by: Joseph Heenan <joseph@heenan.me.uk>
Co-authored-by: Joseph Heenan <joseph@heenan.me.uk>
Co-authored-by: Joseph Heenan <joseph@heenan.me.uk>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com> Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
|
Thanks @pmhsfelix - I've rereviewed the latest changes and they look good to me and I believe resolve all comments in a sensible manner. We have 3 approvals, got wide consensus on the grouping calls & mailing list for this change, and it's been open over a week and I believe has resolved all comments in a sensible manner so merging! |
5 participants
This PR removes the Batch Credential Endpoint, following the discussion and decisions in #18.
closes #18
@jogu pointed out that this would close some other issues too, probably one of these: https://github.com/openid/OpenID4VCI/issues?q=is%3Aissue+is%3Aopen+label%3Abatch-deferred