Fix c_nonce language; may fix #331 #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awoie
requested review from
David-Chadwick,
Sakurann,
bc-pi,
c2bo,
jogu,
nemqe,
paulbastian,
peppelinux and
tplooker
Sakurann
reviewed
Jul 16, 2024
Sakurann
reviewed
Jul 16, 2024
Sakurann
reviewed
Jul 16, 2024
Sakurann
reviewed
Jul 16, 2024
Sakurann
approved these changes
Jul 16, 2024
Collaborator
Sakurann
left a comment
Sakurann
left a comment
There was a problem hiding this comment.
small nits here and there but overall looks good.
nemqe
reviewed
Jul 16, 2024
nemqe
reviewed
Jul 16, 2024
nemqe
approved these changes
Jul 16, 2024
peppelinux
reviewed
Jul 17, 2024
| ### Credential Issuer Provided Nonce {#issuer-provided-nonce} | ||
|
|
||
| The Credential Issuer that requires the Client to send a key proof of possession of the key material for the Credential to be bound to (`proof`) MAY receive a Credential Request without such a key proof or with an invalid key proof. In such a case, the Credential Issuer MUST provide the Client with a `c_nonce` defined in (#credential-response) in a Credential Error Response using `invalid_proof` error code defined in (#credential-error-response). | ||
| The Credential Issuer that requires the Client to send a key proof of possession of the key material for the Credential to be bound to (`proof` or `proofs`) MAY receive a Credential Request or Batch Credential Request without a or with an invalid server-provided `c_nonce` value included in the `proof` or `proofs` parameter. In such a case, the Credential Issuer MAY provide the Client with a `c_nonce` defined in (#credential-response) in a Credential Error Response or Batch Credential Error Response using `invalid_proof` error code defined in (#credential-error-response). |
Member
There was a problem hiding this comment.
Suggested change
| The Credential Issuer that requires the Client to send a key proof of possession of the key material for the Credential to be bound to (`proof` or `proofs`) MAY receive a Credential Request or Batch Credential Request without a or with an invalid server-provided `c_nonce` value included in the `proof` or `proofs` parameter. In such a case, the Credential Issuer MAY provide the Client with a `c_nonce` defined in (#credential-response) in a Credential Error Response or Batch Credential Error Response using `invalid_proof` error code defined in (#credential-error-response). | |
| The Credential Issuer MAY accept a Credential Request or Batch Credential Request that lacks a valid `c_nonce` value in the `proof` or `proofs` parameter. In such cases, the Credential Issuer MAY respond with a Credential Error Response or Batch Credential Error Response, providing a `c_nonce` as specified in (#credential-response) and using the `invalid_proof` error code as defined in (#credential-error-response). |
TODO: remove the bach endpoint ref when the related PR will be merged!
Contributor
Author
There was a problem hiding this comment.
This does not sound right to me. If the credential issuer accepts the proof(s) without a nonce, it is a bit misleading to say that under this condition, the issuer may provide a c_nonce.
Member
There was a problem hiding this comment.
I have just reworded what I understood from your text trying to simplify the reading.
Contributor
There was a problem hiding this comment.
why is Batch still in here?
Contributor
Author
There was a problem hiding this comment.
@peppelinux i updated the text to make it more readable. please also check @Sakurann
peppelinux
reviewed
Jul 17, 2024
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Co-authored-by: Nemanja Patrnogic <3052405+nemqe@users.noreply.github.com>
jogu
approved these changes
Aug 6, 2024
Contributor
jogu
left a comment
jogu
left a comment
There was a problem hiding this comment.
Some trivial suggestions but basically looks good to me, thanks Oliver!
Co-authored-by: Joseph Heenan <joseph@authlete.com>
Co-authored-by: Joseph Heenan <joseph@authlete.com>
Co-authored-by: Joseph Heenan <joseph@authlete.com>
nemqe
reviewed
Aug 12, 2024
c2bo
reviewed
Aug 13, 2024
Co-authored-by: Christian Bormann <8774236+c2bo@users.noreply.github.com>
c2bo
approved these changes
Aug 14, 2024
bc-pi
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May fix #331.
out of scope of this PR: