Jump to conversation
Unresolved conversations (5)
@tlodderstedt tlodderstedt Sep 26, 2024
do we really need to state this again?
...d-4-verifiable-credential-issuance-1_0.md
@tlodderstedt tlodderstedt Sep 26, 2024
do we really need to state this again?
...d-4-verifiable-credential-issuance-1_0.md
jogu
Joseph Heenan
@ju-cu ju-cu Sep 13, 2024
Does that include unknown data fields in an `openid_credential` within the `authorization_details` structure? RFC 9396, Section 7.1 states that the AS may enrich `authorization_details` in the Token Response. Since we added extensibility for the `openid_credential` type, I think we should be clear on how the Wallet must treat a response with unknown data fields. We can add a normative statement here or under #(authorization-details. @pmhsfelix had the same concern [in another comment](https://github.com/openid/OpenID4VCI/pull/382#discussion_r1757151581) and suggested that the Wallet MUST ignore any unrecognized data fields.
Outdated
...d-4-verifiable-credential-issuance-1_0.md
ju-cu selfissued
pmhsfelix
Judith, Michael B. Jones, and Pedro Felix
@ju-cu ju-cu Sep 13, 2024
I wonder if this extensibility is actually compliant with RAR. Section 5 of RFC 9396 states that: > The AS MUST abort processing and respond with an error `invalid_authorization_details` to the client if [an object in the authorization_details structure] [...] is an object of known type but containing unknown fields, Does the proposed extensibility mean that, when it comes to the `openid_credential` type, there are no "unknown fields" because by definition, any unrecognized field gets ignored and consequently all fields are expected and thus "known"?
Outdated
...d-4-verifiable-credential-issuance-1_0.md
bc-pi Sakurann
selfissued
Brian Campbell, Kristina, and Michael B. Jones
@pmhsfelix pmhsfelix Sep 12, 2024
Since the `authorization_details` in the authorization request is created by the wallet itself, does it make sense to state that "The Wallet MUST ignore any unrecognized parameters"? Perhaps this sentence should be in the `token-response` section, where the `authorization_details` is generated by the AS.
Outdated
...d-4-verifiable-credential-issuance-1_0.md
pmhsfelix selfissued
Pedro Felix and Michael B. Jones
Resolved conversations (9)
@Sakurann Sakurann Sep 26, 2024
```suggestion Note that this effectively defines an authorization details type that is never considered invalid due to unknown fields. ```
Outdated
...d-4-verifiable-credential-issuance-1_0.md
@bc-pi bc-pi Sep 25, 2024
```suggestion Note that this effectively defines the type such that it is never considered invalid due to unknown fields. ```
Outdated
...d-4-verifiable-credential-issuance-1_0.md
@Sakurann Sakurann Sep 19, 2024
```suggestion ```
Outdated
...d-4-verifiable-credential-issuance-1_0.md
selfissued
Michael B. Jones
@pmhsfelix pmhsfelix Sep 19, 2024
```suggestion The Wallet MUST ignore any unrecognized parameters in the Token Response. An included `authorization_details` parameter MAY also have additional data fields defined and used when the `type` value is `openid_credential`. The Wallet MUST ignore any unrecognized data fields in the `authorization_details` present in the Token Response.
Outdated
...d-4-verifiable-credential-issuance-1_0.md
Sakurann
Kristina
@ju-cu ju-cu Sep 13, 2024
```suggestion "The AS MUST abort processing and respond with an error `invalid_authorization_details` to the client if [an object in the authorization_details structure] ... ```
Outdated
...d-4-verifiable-credential-issuance-1_0.md
@ju-cu ju-cu Sep 13, 2024
```suggestion The Credential Issuer MUST ignore any unrecognized data fields. ``` Technically, the key/value pairs in the authorization details object are not parameters...
Outdated
...d-4-verifiable-credential-issuance-1_0.md
selfissued
Michael B. Jones
@ju-cu ju-cu Sep 13, 2024
```suggestion The Wallet MUST ignore any unrecognized parameters. ```
Outdated
...d-4-verifiable-credential-issuance-1_0.md
@Sakurann Sakurann Sep 10, 2024
```suggestion Additional `authorization_details` parameters MAY be defined and used, when the `type` value is `openid_credential`, as described in [@!RFC9396]. ``` I don't think we want to allow new `type` values? even if we do, this text should be clearer if we allow new type values or more extensions to type openid_credential
Outdated
...d-4-verifiable-credential-issuance-1_0.md
jogu selfissued
Joseph Heenan and Michael B. Jones
@nemqe nemqe Sep 1, 2024
Not that I don't agree with this, I am just curious to see why this text is formulated in this way as this one breaks the pattern of "receiver decides". I ask because a Credential Issuer can contain a wide set of optional `proof_type`s, and I expected a sentence like: "Wallet MUST ignore any unrecognized proof types from Credential Issuer Metadata." "Credential Issuer MUST reject any Credential Request containing an unrecognized proof type." but maybe that is implied by the text.
Outdated
...d-4-verifiable-credential-issuance-1_0.md
bc-pi Sakurann
nemqe
Brian Campbell, Kristina, and Nemanja Patrnogic