Draft for wallet attestation #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakurann
requested review from
Sakurann,
awoie,
babisRoutis,
bc-pi,
c2bo,
danielfett,
jogu,
peppelinux,
pmhsfelix,
samuelgoto,
selfissued and
tplooker
peppelinux
reviewed
Oct 28, 2024
peppelinux
reviewed
Oct 28, 2024
Co-authored-by: Giuseppe De Marco <demarcog83@gmail.com>
Collaborator
peppelinux
requested changes
Nov 7, 2024
Co-authored-by: Giuseppe De Marco <demarcog83@gmail.com>
Sakurann
reviewed
Nov 12, 2024
Sakurann
reviewed
Nov 12, 2024
Contributor
David-Chadwick
left a comment
David-Chadwick
left a comment
There was a problem hiding this comment.
I do not see anywhere in this draft that says that the wallet attestation should be displayable to the user, as a means of engendering the user's trust in the wallet app. The current text is concerned with transferring the wallet attestation between system components, which is important. But so is display to the user.
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
peppelinux
reviewed
Nov 14, 2024
peppelinux
reviewed
Nov 14, 2024
peppelinux
reviewed
Nov 14, 2024
peppelinux
reviewed
Nov 14, 2024
paulbastian
commented
Dec 6, 2024
paulbastian
commented
Dec 6, 2024
paulbastian
commented
Dec 6, 2024
paulbastian
commented
Dec 6, 2024
paulbastian
commented
Dec 6, 2024
tlodderstedt
approved these changes
Dec 6, 2024
Contributor
Author
|
@pmhsfelix Torsten and I simplified the text a lot, please have a look |
c2bo
approved these changes
Dec 6, 2024
Co-authored-by: Christian Bormann <8774236+c2bo@users.noreply.github.com>
paulbastian
commented
Dec 6, 2024
Co-authored-by: Christian Bormann <8774236+c2bo@users.noreply.github.com>
peppelinux
reviewed
Dec 8, 2024
peppelinux
reviewed
Dec 8, 2024
peppelinux
reviewed
Dec 8, 2024
Co-authored-by: Giuseppe De Marco <demarcog83@gmail.com>
peppelinux
approved these changes
Dec 12, 2024
Sakurann
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #355
Closes #406