change credential type identifier vc+sd-jwt to dc+sd-jwt
#415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Charsley <charsleysa@gmail.com>
Sakurann
approved these changes
Nov 15, 2024
Collaborator
Sakurann
left a comment
Sakurann
left a comment
There was a problem hiding this comment.
Thank you so much for doing this PR!!
Collaborator
|
@charsleysa can you please sign OIDF's IPR agreement so that we can accept contributions from you and merge this PR? thank you! |
c2bo
approved these changes
Nov 15, 2024
Contributor
Author
|
@Sakurann I signed yesterday using the online docusign form, is there any other steps I need to perform? |
babisRoutis
approved these changes
Nov 18, 2024
Contributor
babisRoutis
left a comment
babisRoutis
left a comment
There was a problem hiding this comment.
LGTM.
Checked also the issued credential.
paulbastian
approved these changes
Nov 19, 2024
jogu
changed the title
vc+sd-jwt to dc+sd-jwtvc+sd-jwt to dc+sd-jwt
jogu
reviewed
Nov 19, 2024
selfissued
approved these changes
Nov 19, 2024
Signed-off-by: Stefan Charsley <charsleysa@gmail.com>
bc-pi
approved these changes
Nov 19, 2024
tplooker
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #414