remove c_nonce_expires_in from nonce response #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-pi
reviewed
Nov 20, 2024
peppelinux
reviewed
Nov 26, 2024
tplooker
force-pushed
the
tl/c-nonce-expires-removal
branch
from
8b33213 to
ea153bc
Compare
tplooker
requested review from
Sakurann,
babisRoutis,
bc-pi,
jogu and
peppelinux
and removed request for
bc-pi
Contributor
Author
|
Thanks all, I have updated the PR to remove this sentence, I also added one sentence to the c_nonce definition to make it clear the expectations around its unpredictability and uniqueness across responses from the nonce endpoint. |
leecam
approved these changes
Nov 29, 2024
babisRoutis
approved these changes
Nov 29, 2024
jogu
reviewed
Nov 29, 2024
awoie
reviewed
Nov 29, 2024
awoie
approved these changes
Dec 2, 2024
paulbastian
approved these changes
Dec 3, 2024
jogu
approved these changes
Dec 3, 2024
c2bo
approved these changes
Dec 3, 2024
bc-pi
approved these changes
Dec 3, 2024
Member
bc-pi
left a comment
bc-pi
left a comment
There was a problem hiding this comment.
The statement that this "value MUST be unpredictable" is a bit odd to me but who am I to judge?
nemqe
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #394