Skip to content

Conversation

@c2bo
Copy link
Member

@c2bo c2bo commented Dec 21, 2024

Fixes #435

I just copied the other media types entry, adjusted some text and kept Torsten as author - hope that is fine @tlodderstedt ?

Copy link
Collaborator

@Sakurann Sakurann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key-attestaion+jwt is clearer

### application/keyattestation+jwt

* Type name: `application`
* Subtype name: `keyattestation+jwt`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Subtype name: `keyattestation+jwt`
* Subtype name: `key-attestation+jwt`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would need to update the actual text and example(s) in the document too

@c2bo
Copy link
Member Author

c2bo commented Feb 10, 2025

Changed it from keyattestation+jwt to key-attestation+jwt in the media type registration and key attestation section

@c2bo c2bo requested a review from Sakurann February 10, 2025 11:02
@Sakurann Sakurann changed the title IANA considerations for keyattestation+jwt IANA considerations for key-attestation+jwt Feb 11, 2025
@Sakurann Sakurann merged commit 44de718 into main Feb 11, 2025
2 checks passed
@Sakurann Sakurann changed the title IANA considerations for key-attestation+jwt [breaking] IANA considerations for key-attestation+jwt Feb 11, 2025
@Sakurann Sakurann added this to the Final 1.0 milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

keyattestation+jwt looks like it needs an entry in IANA considerations section

6 participants