Add clarification about client_id for wallet attestation #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2bo
requested review from
Sakurann,
jogu,
paulbastian,
peppelinux and
tlodderstedt
c2bo
commented
Jan 9, 2025
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
c2bo
force-pushed
the
431-client-id-during-issuance
branch
from
b01b480 to
27ccee1
Compare
paulbastian
approved these changes
Jan 27, 2025
Sakurann
reviewed
Feb 5, 2025
|
|
||
| ### Wallet Attestation Subject {#walletattestation-sub} | ||
|
|
||
| The Wallet Attestation as defined in (#wallet attestation) SHOULD NOT introduce a unique identifier specific to a single client. |
Collaborator
There was a problem hiding this comment.
Suggested change
| The Wallet Attestation as defined in (#wallet attestation) SHOULD NOT introduce a unique identifier specific to a single client. | |
| The Wallet Attestation as defined in (#walletattestation) SHOULD NOT introduce a unique identifier specific to a single client. |
Collaborator
There was a problem hiding this comment.
shouldn't this be "MUST NOT"?
Member
Author
There was a problem hiding this comment.
Good question and for most systems I would agree. There might be ecosystems with other privacy properties and I wasn't sure if we should disallow that in the core spec -> I went with SHOULD, but I am happy to change
Collaborator
There was a problem hiding this comment.
but wallet attestation format is defined in VCI, right? so i think it should be MUST NOT. i might be short sighted but what other privacy property can there be?
Collaborator
There was a problem hiding this comment.
I am happy to continue the discussion in openid/OpenID4VC-HAIP#171
Sakurann
reviewed
Feb 5, 2025
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Sakurann
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #431
Adds small text sections that explains how
subof the Wallet Attestation JWT works and should be chosen