clarify batch management in the Wallet when the new batch of the credentials was received #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakurann
requested review from
awoie,
bc-pi,
c2bo,
danielfett,
paulbastian and
tplooker
c2bo
reviewed
Feb 4, 2025
Co-authored-by: Christian Bormann <8774236+c2bo@users.noreply.github.com>
c2bo
approved these changes
Feb 5, 2025
jogu
reviewed
Mar 18, 2025
Co-authored-by: Torsten Lodderstedt <torsten@lodderstedt.net>
tplooker
approved these changes
Apr 17, 2025
tplooker
reviewed
Apr 27, 2025
Contributor
There was a problem hiding this comment.
Related to #472 I think we need to merge the language there as how do you know whether the batch you have just received is materially different to the last one, if you are just obtaining new copies of a credential and the claim values are the same why should you be forced to delete the copies you have at the moment?
tplooker
requested changes
Apr 27, 2025
Contributor
tplooker
left a comment
tplooker
left a comment
There was a problem hiding this comment.
Changing my review based on above comment, easy to resolve I just think we need to check these PR's are consistent with one and other.
Collaborator
Author
|
WG discussion:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #124