Skip to content

Conversation

@javereec
Copy link
Contributor

@javereec javereec commented Feb 5, 2025

Fixes #304

I think this is self-explanatory. I chose to move it before the Key Attestation and Wallet Attestation parts as they refer to Proof Types so it felt more intuitive. I hope that's okay.

@c2bo
Copy link
Member

c2bo commented Feb 5, 2025

Just a quick reminder before I forget: This will very likely shift references from HAIP (and maybe also OpenID4VP) -> when this gets merged, we should check and fix those if necessary.

@Sakurann
Copy link
Collaborator

Sakurann commented Feb 5, 2025

You're right Christian. given that, is this worth the change..?

@c2bo
Copy link
Member

c2bo commented Feb 5, 2025

I like the change - I think it improves readability. I can make the fixes after this merge in both specs and just wanted to make sure we don't forget

@Sakurann
Copy link
Collaborator

Sakurann commented Feb 6, 2025

what about ISO specs that reference out specs......?

@tplooker
Copy link
Contributor

what about ISO specs that reference out specs......?

Do you mean the ISO specs would have an issue with referencing an appendix?

@Sakurann
Copy link
Collaborator

Sakurann commented May 5, 2025

wg discussion - agreed we want to do this.

  • move this to the latest annex, so that annex D and E for wallet and key attestations do not get new alphabets
  • @paulbastian to help check

@Sakurann Sakurann added this to the Final 1.0 milestone May 5, 2025
Copy link
Contributor

@paulbastian paulbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather move this to Annex F, as we reference key and wallet attestations as D & E in external documents

@javereec
Copy link
Contributor Author

@paulbastian @c2bo @Sakurann Merged in latest changes from main and moved proof types to appendix F as per last comments. Please review again.

@paulbastian
Copy link
Contributor

Oh damn, I already did that in #489

@javereec
Copy link
Contributor Author

@paulbastian Oh, I see. Would be good to close this PR before you do that next time.

@javereec
Copy link
Contributor Author

Superseeded by #489

@javereec javereec closed this May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider moving Proof Type section to Annex

5 participants