-
Notifications
You must be signed in to change notification settings - Fork 37
Move Proof Types from Credential Endpoint section to an appendix #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Just a quick reminder before I forget: This will very likely shift references from HAIP (and maybe also OpenID4VP) -> when this gets merged, we should check and fix those if necessary. |
|
You're right Christian. given that, is this worth the change..? |
|
I like the change - I think it improves readability. I can make the fixes after this merge in both specs and just wanted to make sure we don't forget |
|
what about ISO specs that reference out specs......? |
Do you mean the ISO specs would have an issue with referencing an appendix? |
|
wg discussion - agreed we want to do this.
|
paulbastian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather move this to Annex F, as we reference key and wallet attestations as D & E in external documents
|
@paulbastian @c2bo @Sakurann Merged in latest changes from main and moved proof types to appendix F as per last comments. Please review again. |
|
Oh damn, I already did that in #489 |
|
@paulbastian Oh, I see. Would be good to close this PR before you do that next time. |
|
Superseeded by #489 |
Fixes #304
I think this is self-explanatory. I chose to move it before the Key Attestation and Wallet Attestation parts as they refer to Proof Types so it felt more intuitive. I hope that's okay.