make credential_signing_alg_values_supported type and values format specific #460
Conversation
… format specific and introduced credential_signing_crv_values_supported for mdocs
awoie
changed the title
Sakurann
left a comment
Sakurann
left a comment
There was a problem hiding this comment.
i think this is an improvement - thank you!
Sakurann
requested review from
bc-pi,
c2bo,
danielfett,
paulbastian and
tplooker
davidz25
left a comment
davidz25
left a comment
There was a problem hiding this comment.
I think this is an improvement, thanks.
(As an aside, would be nice if we could depend on fully specified algorithms - that way we wouldn't need e.g. credential_signing_crv_values_supported. But I don't think we can add that dependency.)
|
agree with David, we should use fully-specified algorithms right away to make things easier. It's close to final and apparently its not a too big of a problem to reference non-final specs. |
If we did this too though we wouldn't be able to point at the COSE IANA registry like we are because the polymorphic algorithm identifiers are already registered there. That would then limit us in being cryptographically agile in future as new PQ algs get finalised. Hopefully fully specified algs just become more common use in future thus making this metadata element redundant. |
|
|
||
| * `doctype`: REQUIRED. String identifying the Credential type, as defined in [@!ISO.18013-5]. | ||
| * `claims`: OPTIONAL. An array of claims description objects as defined in (#claims-description-issuer-metadata). | ||
| * `credential_signing_crv_values_supported`: OPTIONAL. Array of cryptographic curve identifiers that the Issuer uses with one of the algorithms listed in `credential_signing_alg_values_supported` to sign the issued Credential. Curve identifier types and values used are numeric values and SHOULD be one of those COSE eliptic curve values defined in [@IANA.COSE]. Note that `credential_signing_crv_values_supported` MAY be used if one of the algorithms in `credential_signing_alg_values_supported` supports multiple curves. |
There was a problem hiding this comment.
this needs to be changed to align with openid/OpenID4VP#553
Sakurann
left a comment
Sakurann
left a comment
There was a problem hiding this comment.
needs to be changed to align with openid/OpenID4VP#553
|
Closing this PR in favor of #495 |
This PR does:
credential_signing_alg_values_supportedformat specificcredential_signing_alg_values_supportedto COSE algorithm values for mdocscredential_signing_crv_values_supportedto mdoc format because of polymorphic COSE algorithm identifiersFixes #354 and fixes #303
Note that this is also how it is used in 23220-3 atm.