rework the Credential Response text, fix immediate issuance to have HTTP 200 status code #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TTP 200 status code
tplooker
reviewed
May 8, 2025
tplooker
reviewed
May 8, 2025
tplooker
reviewed
May 8, 2025
Co-authored-by: Tobias Looker <tobias.looker@mattr.global>
Co-authored-by: Tobias Looker <tobias.looker@mattr.global>
Co-authored-by: Tobias Looker <tobias.looker@mattr.global>
Sakurann
requested review from
Sakurann,
awoie,
bc-pi,
c2bo,
cre8,
danielfett and
tplooker
awoie
reviewed
May 20, 2025
Sakurann
approved these changes
May 21, 2025
Co-authored-by: Oliver Terbu <oliver.terbu@mattr.global>
awoie
approved these changes
May 23, 2025
tplooker
approved these changes
May 28, 2025
jogu
pushed a commit
to openid-certification/conformance-suite
that referenced
this pull request
Jun 6, 2025
Wording in ID2 Draft 15 says always 202, but that was a mistake. See: https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0-ID2.html#section-8.3 Fixed here openid/OpenID4VCI#490 Fixes #1511 Signed-off-by: Thomas Darimont <thomas.darimont@oidf.org>
jogu
pushed a commit
to openid-certification/conformance-suite
that referenced
this pull request
Jun 6, 2025
Wording in ID2 Draft 15 says always 202, but that was a mistake. See: https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0-ID2.html#section-8.3 Fixed here openid/OpenID4VCI#490 Fixes #1511 Signed-off-by: Thomas Darimont <thomas.darimont@oidf.org> (cherry picked from commit 19a1a4e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing Credential Response having always HTTP status code 202, as discovered during Berlin pre-EIC WG meeting.
Also reordered and simplified some text.